Re: faq/current.html hotplug(4) behaviour change [Was: hotplug(4) r1.10 ignoring hotplug_put_event() prior to hotplugopen()]
MERIGHI Marcus <[email protected]>
| Newsgroups | gmane.os.openbsd.www |
|---|---|
| Message-ID | <[email protected]> |
for the records: discarded, see http://marc.info/?l=openbsd-tech&m=129229197130930 [email protected] (MERIGHI Marcus), 2010.12.13 (Mon) 11:47 (CET): > It is somewhat ugly that the 2010/12/02 change is listed after 2010/12/08 > change. But that is how I read the comment and 2010/12/02 is in fact the > date of tedu@'s change: > http://www.openbsd.org/cgi-bin/cvsweb/src/sys/dev/hotplug.c.diff?r1=1.9;r2=1.10 > > Index: current.html > =================================================================== > RCS file: /cvs/www/faq/current.html,v > retrieving revision 1.249 > diff -u -r1.249 current.html > --- current.html 9 Dec 2010 00:04:26 -0000 1.249 > +++ current.html 13 Dec 2010 10:39:35 -0000 > @@ -38,6 +38,7 @@ > <li><a href="#20101108">2010/11/08 - PostgreSQL update</a> > <li><a href="#20101111">2010/11/11 - Xenocara updates</a> > <li><a href="#20101208">2010/12/08 - [ports] Ruby on Rails update</a> > +<li><a href="#20101202">2010/12/02 - hotplug(4) behaviour change</a> > <!-- New additions go on the bottom, please --> > </ul> > > @@ -267,6 +268,11 @@ > Rails 3 Release Notes</a> have a lot of helpful information > about the upgrade process. > > +<a name="20101202"></a> > +<h3>2010/12/02 - hotplug(4) behaviour change</h3> > +Device attachments are now only queued once the device is opened by userland. > +This entails that device attachments prior to the start of hotplugd(8) are not > +picked up by hotplugd(8) anymore. > > <hr> > <a href= "index.html"><img height= "24" width= "24" src= "../images/back.gif" border= "0" alt="[back]"></a> > > ----- Forwarded message from Ted Unangst <[email protected]> ----- > > Date: Sun, 12 Dec 2010 13:10:42 -0500 > From: Ted Unangst <[email protected]> > To: Ted Unangst <[email protected]>, [email protected] > Subject: Re: hotplug(4) r1.10 ignoring hotplug_put_event() prior to hotplugopen() [Was: hotplugd(8) ignoring devices > attached before boot] > > On Sun, Dec 12, 2010 at 6:36 AM, MERIGHI Marcus <[email protected]> wrote: > > The behaviour change in hotplug(4)/hotplugd(8) after your commit makes > > it more ``hot plug'', actually. What bothers me (but not many others, > > obviously) is the fact that the behaviour change is undocumented. Four > > places come to my mind: > > 1) a comment in hotplug.c with appropriate commit message. > > 2) hotplug(4) man page, ``When a device attaches or detaches, the > > corresponding event is queued'' should (suggestion) read ``Once the > > device is opened by userland, when a device attaches or detaches, the > > corresponding event is queued.'' (I am not a native speaker, so > > please correct me!) > > 3) hotplugd(8) man page, make > > ``The hotplugd daemon monitors the hotplug(4) pseudo-device, acting on > > signaled events by executing the scripts in the /etc/hotplug > > directory.'' read > > ``The hotplugd daemon opens the hotplug(4) pseudo-device and thus > > enables event signaling. It then monitors the device, acting on > > signaled events by executing the scripts in the /etc/hotplug > > directory.'' > > 4) http://www.openbsd.org/faq/current.html > > > > I'd gladly supply patches for any of these. > > That sounds good. I was aware of the change, but didn't think anybody > would notice. :) > > > ----- End forwarded message -----