Re: X bombs on resolution change with savage card

> On Sat, Jul 07, 2007 at 04:47:22PM -0700, Ryan Freeman wrote:
> > 
> > Short description: Any time a program or myself tries to change the X.org
> > resolution while the server is running (modifying the conf and restarting of
> > course works fine) the server will crash with a signal 11. 
> > 
> --snip--
> > 
> > Program received signal SIGSEGV, Segmentation fault.
> > 0x06175849 in SavageDoAdjustFrame ()
> >    from /usr/X11R6/lib/modules/drivers/savage_drv.so
> > (gdb)
> > Continuing.
> > 
> > Program terminated with signal SIGSEGV, Segmentation fault.
> > The program no longer exists.
> > (gdb)
> 
> --snip--
> 
> It would seem that after I have done this work I have now found that this
> problem may be directly related to the driver rather than an x.org -> openbsd
> problem. If so I apologise for the noise, here is the development I have found
> on a debian mailing list which includes a patch that supposedly remedies or
> 'works around' the problem:
> 
> http://lists.debian.org/debian-x/2007/05/msg00642.html
>

I have confirmed the patch to be working, just checked out the latest xenocara
cvs and applied the following:

Index: src/savage_driver.c
===================================================================
--- src/savage_driver.c 2007-05-13 00:58:41.000000000 +0200
+++ src/savage_driver.c 2007-05-13 01:16:25.000000000 +0200
@@ -3547,6 +3547,7 @@

         /* do it! */
         SavageWriteMode(pScrn, vganew, new, TRUE);
+       pScrn->currentMode = mode;

         if (psav->FBStart2nd) {
            SavageStreamsOn(pScrn);
@@ -3809,6 +3810,7 @@
                     
     /* do it! */    
     SavageWriteMode(pScrn, vganew, new, TRUE);
+    pScrn->currentMode = mode;
                               
     if (psav->FBStart2nd) {   
         SavageStreamsOn(pScrn);

directly from the above url. Credit goes to whomever made that post.
I am no coder so I don't know if this would be considered an 'acceptable' fix
or not, i'm hoping this would be something that can be integrated into xenocara
but from the looks of it, it should actually go directly to the x.org devs.
Thanks and best regards,

-ryan