Re: intel driver crash (was: Re: mplayer restarting openbsd)
frantisek holop <[email protected]> Sat, 12 Dec 2009 19:00:23 +0100
| Newsgroups | gmane.os.openbsd.x11 |
|---|---|
| Message-ID | <[email protected]> |
hmm, on Thu, Dec 10, 2009 at 03:36:57PM +0000, Owain Ainsworth said that > from upstream: > > Author: Barry Scott <[email protected]> > Date: Tue Jun 23 14:14:50 2009 +0100 > > Fix segv for clipped movie window > > When playing a movie that is clipped on its left and right edges the > Xorg server will SEGV sometimes. This is because the intel driver > ignores the clipping info when it copies the planes out of the XV > data. The check for the optimised copy was wrong to ignore the > width required. Which leads to too much data being copied by the > memcpy. It the source buffe happens to end exactly on a page > boundary the server will SEGV. > > As we reviewed the code we checked the calculation of src1, src2 and > src3. The patch includes additional comments to make it clear what > the elements of the calculation are. > > This bug exists in git head and we also see it in 2.4.1. this seems to fix the issue, and so far some other weird X lockup issues as well. thank you for the assistance. -f -- god? i'm no god. god has mercy.