Re: Please commit patches for php5 and php4

On Aug 25, 2006, at 07:16, Juan Manuel Palacios wrote:

> On Aug 24, 2006, at 5:33 AM, Ryan Schmidt wrote:
>
>> Can somebody with commit access please update the php4 and php5  
>> ports? Someone has already submitted a patch for the php4 port:
>>
>> http://bugzilla.opendarwin.org/show_bug.cgi?id=10501
>
> Randall committed this one not long ago.

Great!


>> I tried to assign it to the maintainer's email address but  
>> Bugzilla said it was invalid.
>
> There are Bugzilla restrictions in place, so some actions are not  
> available to everyone.

I'm aware of those restrictions, but I've always been able to assign  
ports to their maintainers before. Here, Bugzilla specifically stated  
that the maintainer's email address I entered was not valid, as if  
that email address was not associated with any Bugzilla user.


>> Here's a patch for the php5 port:
>>
>> http://bugzilla.opendarwin.org/show_bug.cgi?id=10535
>>
>> I'm the maintainer of php5.
>
> I just committed this. A small note, the default revision is always  
> zero, so no need to included it explicitly. Other than that, the  
> patch was in good shape!

Thanks. I'm aware of the revision-0 default; it's just that when I  
later revise the port to revision 1, it's easier to change the 0 to a  
1 than to have to look up again what the syntax is.