Re: [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

My 2 cents,

I'd think it better specfies the hex values are BugCheck codes, not another error number set's values. That it's being output to the debug console is indication enough to most it's a System Error. :-) I'd keep "Fatal " before it to keep the emphasis it isn't considered recoverable, however.


------ Original message------
From: Alex Ionescu
Date: Wed, Feb 7, 2018 7:57 PM
To: ReactOS Development List;Serge Gautherie;
Cc: Linda Wang;
Subject:Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal SystemError" with "BugCheck"

This changes documented/external behavior. What is the point of this change?
Best regards,
Alex Ionescu


On Wed, Feb 7, 2018 at 1:22 PM, Serge Gautherie
<[email protected]> wrote:
> https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.reactos.org%2F%3Fp%3Dreactos.git%3Ba%3Dcommitdiff%3Bh%3D6ece4e9fc22d664ea2485d04303e8ae10047f21f&data=02%7C01%7C%7C07f72d23c7154dbb109808d56e8ee12b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636536482305756863&sdata=DbtnfYUd00t%2BYpPtbbO16z9iLVUC3xrg2hsmdQKoMTQ%3D&reserved=0
>
> commit 6ece4e9fc22d664ea2485d04303e8ae10047f21f
> Author:     Serge Gautherie <[email protected]>
> AuthorDate: Wed Feb 7 06:29:02 2018 +0100
> Commit:     Pierre Schweitzer <[email protected]>
> CommitDate: Wed Feb 7 22:22:28 2018 +0100
>
>     [NTOS:KE] Replace "Fatal System Error" with "BugCheck"
> ---
>  ntoskrnl/ke/bug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ntoskrnl/ke/bug.c b/ntoskrnl/ke/bug.c
> index a92acb1bab..2127d7207c 100644
> --- a/ntoskrnl/ke/bug.c
> +++ b/ntoskrnl/ke/bug.c
> @@ -1070,8 +1070,8 @@ KeBugCheckWithTf(IN ULONG BugCheckCode,
>      if ((BugCheckCode != MANUALLY_INITIATED_CRASH) && (KdDebuggerEnabled))
>      {
>          /* Crash on the debugger console */
> -        DbgPrint("\n*** Fatal System Error: 0x%08lx\n"
> -                 "                       (0x%p,0x%p,0x%p,0x%p)\n\n",
> +        DbgPrint("\n*** BugCheck: 0x%08lx\n"
> +                 "             (0x%p,0x%p,0x%p,0x%p)\n\n",
>                   KiBugCheckData[0],
>                   KiBugCheckData[1],
>                   KiBugCheckData[2],
>

_______________________________________________
Ros-dev mailing list
[email protected]
https://nam02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.reactos.org%2Fmailman%2Flistinfo%2Fros-dev&data=02%7C01%7C%7C07f72d23c7154dbb109808d56e8ee12b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636536482305756863&sdata=clqNd6j4Om0TgI672QslfNkmY%2BJYUDxYchX5oTwDQpg%3D&reserved=0

_______________________________________________
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev