Re: [ros-diffs] 03/03: [OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber.

Pierre Schweitzer <[email protected]> Sun, 18 Nov 2018 21:05:47 +0100
Newsgroups gmane.os.reactos.kernel
Message-ID <[email protected]>
I'm not sure I understand this commit, nor the PR that was merged before.
This is a synced module, for a Vista+ export... What's the point of this?
It would have been better to sync with Wine and have this patch upstream.

Le 18/11/2018 à 21:03, Hermès Bélusca-Maïto a écrit :
> https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2d320f5a8daf4627458e81f0ffd51bdd8f60d120
> 
> commit 2d320f5a8daf4627458e81f0ffd51bdd8f60d120
> Author:     Hermès Bélusca-Maïto <[email protected]>
> AuthorDate: Sun Nov 18 21:05:32 2018 +0100
> Commit:     Hermès Bélusca-Maïto <[email protected]>
> CommitDate: Sun Nov 18 21:06:22 2018 +0100
> 
>     [OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber.
> ---
>  dll/win32/ole32/ole32.spec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dll/win32/ole32/ole32.spec b/dll/win32/ole32/ole32.spec
> index d4ed1163d4..97667918e9 100644
> --- a/dll/win32/ole32/ole32.spec
> +++ b/dll/win32/ole32/ole32.spec
> @@ -23,7 +23,7 @@
>  # CoCreateObjectInContext
>  # CoDeactivateObject
>  @ stdcall -stub CoDisableCallCancellation(ptr)
> -@ stdcall -stub CoDisconnectContext(long)
> +@ stdcall -stub -version=0x600+ CoDisconnectContext(long)
>  @ stdcall CoDisconnectObject(ptr long)
>  @ stdcall CoDosDateTimeToFileTime(long long ptr) kernel32.DosDateTimeToFileTime
>  @ stdcall -stub CoEnableCallCancellation(ptr)
> 


-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

_______________________________________________
Ros-dev mailing list
[email protected]
http://reactos.org/mailman/listinfo/ros-dev
signature.asc (application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE+qe4Wfh6h6eUzdawdUVVbD1YWwsFAlvxxiUACgkQdUVVbD1Y
WwtP5Q//fFD2Hj4gIswKnoYiaJ226a38eMJU8nB2BA6y2nXRjm4lMhyYYpn/y69P
CYX6S30Ip9J/0FhJVXKilXuJ880WeklBRZbdIpA//2C+qar0GRNIBmgGscBM8FMj
+a/jRhaDT1ucfpxEvH2MFgSU2x5HpE8izcRlk2IlJ1zNemVRY+OcYSO8204bK8BN
IF8xNi0PvAqDXtWblB+BMO949kwriznDBjnkW/bVIv3jJTCavbkNAqX0gCDdmGKL
G2+zmxb4GNzy8KBQEQ5u7TV0ZH45yLeF+NeeYWm3YQ2koACxaYoCd/zH5FIVGxCD
jEwyg6tyBFpRr1u0d3+qAbbFtXwZ+IachtIgPaSSVOXcUPhwrx57XVxt+z7CtVRd
ajx9/De42eGJC3h0XWS6mO7OykTxzlNuEBlummfzeHXOgBloQV63QB0PQFzZC39B
6dD/H9UTAbaxGUlIW5tkCZRGfu6509HqAUyWEcP4Tj+LqIlh7TZQbd0X1yNFzmK5
Mjh9kRGt3h+z2cpn8PZwIe7AESZneAnFM/WiUn/Ha5yolDSvKSokHwJwU4d5Ur9h
cQpNNyTsQL9yz1u3cT63z37zLssxb84093DLjxW8NKNisotDyh5yHp1xcj6ZVX6g
jS3GU92hbbogwMFAtJqVgPcgp40SCx0zMzyeztm7Aq3MucfuBL8=
=pgJG
-----END PGP SIGNATURE-----