Re: [ros-diffs] [reactos] 06/12: [EXT2] Correctly zero memory before using it

Pierre Schweitzer <[email protected]> Mon, 1 Apr 2019 19:15:53 +0200

Newsgroups	gmane.os.reactos.kernel
Message-ID	<[email protected]>

This is 3rd party code. Can you surround it with #ifdef __REACTOS__?

Le 01/04/2019 à 17:08, Hervé Poussineau a écrit :
> https://git.reactos.org/?p=reactos.git;a=commitdiff;h=76910c358f7197a6b8e283ea267faf7b5c1812ff
> 
> commit 76910c358f7197a6b8e283ea267faf7b5c1812ff
> Author:     Hervé Poussineau <[email protected]>
> AuthorDate: Sat Mar 30 23:06:27 2019 +0100
> Commit:     Hervé Poussineau <[email protected]>
> CommitDate: Mon Apr 1 11:38:32 2019 +0200
> 
>     [EXT2] Correctly zero memory before using it
> ---
>  drivers/filesystems/ext2/src/memory.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/filesystems/ext2/src/memory.c b/drivers/filesystems/ext2/src/memory.c
> index 8915dfeccb..cf569f40cd 100644
> --- a/drivers/filesystems/ext2/src/memory.c
> +++ b/drivers/filesystems/ext2/src/memory.c
> @@ -2072,9 +2072,9 @@ Ext2ParseRegistryVolumeParams(
>  
>      USHORT i, j, k;
>  
> -    RtlZeroMemory(Codepage, CODEPAGE_MAXLEN);
> -    RtlZeroMemory(Prefix, HIDINGPAT_LEN);
> -    RtlZeroMemory(Suffix, HIDINGPAT_LEN);
> +    RtlZeroMemory(Codepage, sizeof(WCHAR) * CODEPAGE_MAXLEN);
> +    RtlZeroMemory(Prefix, sizeof(WCHAR) * HIDINGPAT_LEN);
> +    RtlZeroMemory(Suffix, sizeof(WCHAR) * HIDINGPAT_LEN);
>      RtlZeroMemory(MountPoint, sizeof(USHORT) * 4);
>      RtlZeroMemory(DrvLetter, sizeof(CHAR) * 4);
>  
> 


-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

_______________________________________________
Ros-dev mailing list
[email protected]
http://reactos.org/mailman/listinfo/ros-dev

signature.asc (application/pgp-signature, 833 B)