First Contact

Raymond Czerny <[email protected]> Mon, 21 Mar 2022 00:01:14 +0100
Newsgroups gmane.os.reactos.kernel
Message-ID <7359416.EvYhyI6sBW@atomix2>
This is a multi-part message in MIME format.

--nextPart3656785.kQq0lBPeGt
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

Hello,

my name is Raymond.

I have a patch for you, with a reimplentation of IsReactOS() in reactos/sdk/include/psdk/versionhelpers.h.
This function was marked FIXME.
The old check with installation directory is error prone.
My implementation read the field "ProductName" of VersionsInformation resource from shell32.dll.

A second problem, I have found in  reactos/dll/win32/comdlg32/filedlg.c.
Duplicates in the function filedlg_collect_places_pidls().
My resolve used a little function collection in the files cstrlist.c and cstrlist.h.
In filedlg-snipped.c is the new code.

I don't know if this approach is desirable and where such helper functions should be placed. 
So decide for yourself about their use.

I hope this little step is a good begin.

Greetings
Raymond

--nextPart3656785.kQq0lBPeGt
Content-Disposition: attachment; filename="reactos.patch.zip"
Content-Transfer-Encoding: base64
Content-Type: application/zip; name="reactos.patch.zip"

UEsDBBQAAgAIAPm0dFS+3o6gzQMAACEJAAAiAAAAMDAwMS1Jc1JlYWN0T1MtcmVpbXBsZW1lbnRl
ZC5wYXRjaJVV+2+iWBT+nb/ijJNMIL4Q0aqzbkoVRxN8rLTaZGwMj2tlBsG5wHRtt//7ngvoUHXa
zo3JxfP4znceHHrU30DTuGiu5NqFLDWMmtis12sVqVZv1qy6aTfMhtW4IBWz0bRg6Hugky1ULkAU
W/EPJFGscD2EacHU2G18z4bOI6HeDv6y1s72kqLQCfxVWLLJ31zXCEkL9MgroCMMDYqXJIEktarN
llyHvFgRRU6PzG/EClvwdaJcd/p3MAimxLDCsc4LQImz2bpkQ7yQ2BxXLBY5COzvZcez3Mgm5S37
85PQwPG9NXG3+FRaw38gNyH/yolxKrByXALW2vDuiV0AuQaOFxAaIlbA5wWUgE1ckvwvChxnO6sV
FIv3TghG+W0a5ts2nOPZ5F+oVpuGbIuWbcilkmWtCPbGbFRrgAWqyzLL+z0ROUztXVEvL6FYkRsF
rBK7aiKgZBAoVuj8JDoJmHXHj7xQczYOVp4XOJipU30wHvVVbaJOlcmAyzaKgyeuCHjKZegNbodq
C3qYGhhgkjAkFDYkXPv2h8Ro3ukrUwge547XdejXoXK7xN737z4n6i8kRI3tPwSoxdHw6W7O760L
sLQYM391EAlC6khJGFEP+AcrCEKacdFyKdOcAB/aMLrRNPTJM5+r8Vhjt6k5Zo8SAm3oKZqupur+
cNy90VRYD30bVUgNHyKX9A3Pdsmc13IBltWtSrk9oLPiRWi3Yw8hET0lFzspjuYbNgakBkvtFOOI
EM8IM+IxZmrzzOUPAc/H2pe5F7nuxAjX2UIfjLrz8bQL9oNGvGx+PXw1RsYGM2TYhQxKAfYwWbZI
IsYQfokyTNjJ8Igt7zCc+JkNDCU/Imy0DeYO0sbD7WSf3jFR3XkkCVPGcZaM9sBb+UzB5uQX0Wyf
XxBlpsJL+RHb7GhQEkRueDQY2XMzGF2z27LWyCfO69RIm3Tm+vUU3OBxZrgRy4HxO2PZV0ZdHDns
NtmwTF3fNFzFdX2L/zJUh8vheKYqV5paSKshnI02Gw+6AMiH1QYOOJpvfecZ8jmv06K+LKio7WMW
9sjnYOLCmR1/szXw09Bmpv9EhO7ivOd86lk4dXz9aLnFQg+p490zkgxisRBlsSnKV+JiMaE4uFbI
hjb3x9B8Ui/h0747f4zwKWn+uXLgyO2LIZxqn85HOgzd4eVPt9qBYXarnQv7fKa/8QjceO6rQxAb
sdXzWxOWUbqe3p8Rs053Hp9dZG9wTpd6Uo8jl4z589FWTN3SVxbl8JF4+AFnC2e5nKpK53qsL5f4
aQVOKkm1UoXj/gdQSwMEFAACAAgA7RRzVCXuIxP1BQAAQyEAAAoAAABjc3RybGlzdC5j7VdLc9pI
EL7rV/RmL8JgG9jdHEJIlrjshCriuAAX61woIY3MVISGjEbIZMv/fXtGD/R0IMZ2vLtcgJmefnw9
3T3f8cGBBgfwp00dAqYnuEM9cWSqtRmnxIbPhDPwyNLghiAWoAh1r0GJoZQUPGHLNafXcwHtZrsN
Q2O9YK4FJ98Id9eRzHhOPTw04wZfA/60OSHgMVsEBicdWDMfTMMFTiwqLcx8QYAKMFzrmHGpYMEs
aq/lmu9ahIOYExCELzxgtvrz/vwSBsTzcO89cQk3HLjwZw5VsQyoSVyPgOHBUi56cwxltlYHz6Qr
o8gVOGOo3xCUuR0gFPeV9RXhHi5B+6gV24tUNoBx0A0hQ+DAlvJkDf1eg4N48fjkUQUOm3AtoK5S
PGdLDG2OKjHYgDoOzAj4HrF9pyFVoDBM+uMPny7H0Du/gklvOOydj686KCzmDHfJioSq6GLpUNSM
kXHDFWv0XWr4eDo8+YBHeu/6g/74SkZw1h+fn45GcPZpCD246A3H/ZPLQW8IF5fDi0+j0yOAESEx
0ArSMqwToG3UuWCIp0WEQR0vjv8KE+2hk44Fc2NFMOEmoSt00QATr9FuyXQY3kQZNJ7ZwNoBaoPL
RAMCTvEaCVZMs1SzyXQD+q551IA/WihluF8czMQIz59RG3WfOYzxBrxjnpCiH3vQbLdazcPWb81W
Ay5HPVR2rGnar9Q1Hd8i8Jp67OXvL4/mb1JrnrDQv/yarCW5tll8kRTh/IWmHR9Dt9tFZ5KiC+Md
4V+HHL5bC3J4MsfSNPGueVI2/mjajDEnKempyQneR/0EVQ3w/4FS1gCPfiNTgdj7rqhpf2uAH7lz
+GZGrhGGLpal4zBTVxKhPLN1E23Wap2UOMGK72aO1kOtoRAnwucu6OeXgwG6mRaswVuwDQcT+goE
90lHu9W0FaPWxnmL4C+2znkf+yt7iZ5W2CkJQxou+huuFuyZDjHcCmsRYvIrCVgqO0wbDC0tyMIj
Iu1aA5ohhjVlNZsiY7lERYUUmczFtEvED7AjkEXsSLiyZF4W99A0tfUEaxSpqS4VLygtNSUXqkpl
SGUi1IEOyq9gjrNB15vwSxcOlC7syqBLw6838Rf0yf16V84Lh7i6OleHVqw59lFJxULKLylVy2jO
KUZhc7mWJxthJJ18DOEt2hjKhlaB+9R36VefbA0/ej/qfz6dfuz9JTFNtFEcTzd6ePYuoPNpT534
Ud+ndD/eo57H8p+TBVtVtiXlTXnhNTupIhCLZabEw1VbNviS9eqSSVfMFuWhmg/jeuytdaMcK9ZG
B+p13M3rRIvqTDcONN7YiIQmwjhQayezMcOe/mWzdLtb7cXBKvXbhlulWW3itPLCoY53TkYfm8rj
ka/oYi/NxBqmNxpEUrh0DkUdV/YGPNAA1SCiXptqZ+ikbO8cxwZbRNjiEwHN5m9ZO+eTks10drWS
9PR2bYODYVkKhgzY2EDRs3z0kc+RLuV6yutkwMmTJYWVTMx0pSfltTIcf7vqun9pbMrs0Sojspy5
LLtUQcZzxDB+DSXvAPmAufsdoETy/eg+MKYeTbcPNX/lp14vWMp6UIJHONu2nTHpa7Y9Qj/2bImH
2R6AQx/kE2OxTD0xqi7g90AOgVYIlN1Qgt317qtdejSTrU3kVQnb4VnwfFM2lWTqeSYt17NdciOK
Cat4/ps+x3OYlyzkGa/Sn7fpBFZKvVJaMswtMlSHGLdwIYLutpqqTqj1HY4a5EnqZE8sNZAYTcXD
EdWEOQYFqjp5YK4a5Mjq5JHYapB/90/Ke0uEffbOJos/O2vFKL/PWiOh7VgrCu+FtQYVtHWXNOTI
X7Azdw3uRf6CSva6vyC2orD7CiMisZMfZrFJgHkim2wUuewWtfQvo7N3F+V96GxB8xPR2dzA+p/R
pos/yLHarcptL1XyszLbOwqigtkGOWo72YXb7gXLPdPbUgh2pLf5+bfLFConTA/2ztkvZ5Jvkl0Y
UyXYT0RzizP/P5O6KcZOn2fyShq6oryF3N1NIZ6A+UYQ5pjvP1BLAwQUAAIACAAZFnNUyfyChyIF
AAAxGAAACgAAAGNzdHJsaXN0LmjdWFtv2kgUfudXHKkvKaKQZLVPaVdLUWiRaBoBEZu+oME+jkdr
ZtjxOC6t9r/vN2ObAA4bmu0lXR4IHp/bd27zKZ1ms0FN+j2SCVOQWpPI1LZjfzY3kiP6wEZTykth
hOWQICLVDXkxSDnBnl6ujLyJLZ0en57SSKwWWoXU+8RGrUqZSSxTKM2NMCvCz8gwU6ojmwvDZ7TS
GQVCkeFQOg/zzDJJS0KFHW2cgYUOZbRyZ5kK2ZCNmSybRUo68g9vLq5oyGmKd29YsREJXWbzRAZO
eygDVimTSGnpDtMYUOYrr9h3oYzLUKivYV9YqdUZscR77/2WTYojOm2fVP5Kky3Sho6EdRAM6aXT
fI64V5QgX6bSbO/Jwx3ckKTyhmO9BLQYJgE2l0lCc6Ys5ShLWs4EhGk6mLx9fzWh7sU1TbujUfdi
cn0GYRtrvOVbLkzJxTKRsAxkRii7QuzOwrvzUe8tVLqvB8PB5Noh6A8mF+fjMfXfj6hLl93RZNC7
GnZHdHk1unw/Pm8TjZmrRPuU3pfrdaIj2Fxo5DNkK2SSVvivUegUQSYhxeKWUfCA5S1CFBSgjb6s
mIlGJzrQ0LlL6xnJiJS2LcqNRBtZXS+zM3NX6RYNVNBu0a8nkBLqzwSVGEO/LyPY7idamxa91ql1
ou+6dHx6cnL84uSX45MWXY27MNZpNJ7JCI0ZUW88GQ0H48nsbeMZnqXizSOIqSDJQqaXqQ3nWift
+LftQ6ns9lkexMK4o0anQ69evUJs6xks4I/xmPCL1yvLL3oQFgFaL3Wy1cfrQi8LbGZ8ThZCiZsF
KwzZlv6mceCyqyU7WKnXbXxuED4uoCb+zvlGYk6o02y+pEuNyFEwlNCfux+VlU0lVuGZe95SEpH7
XjB6ZuUU/kbSrBlC/Qyhl0uqWEj9TAWuag6ESBIdYM4qTR1tLiiCUMxi6ZXdAlsUx2uvsOAONt4H
aAqLjea+YczFLHwusYncFkQrWm1Sr2EYuVTUFwmaURaNW8bhNlyWJFgOboPkEgITk7HvFFf09aqd
BYbh4KhC2/QBtSiVn3hmi3Ce11PgevmLINcRdxq3WoZ3gYSMX3q1E0nddy9hLOpAw1yRo50MHugu
cGYedNZdLtEu6NASYr1ge9xVr7EAFnTBObrOIlluLa0lyvqNsyDAqrmnNsJ7r9UG2OGzaGdn/6Cw
XXOsB9Yt6TDDbna9m9JRINAgKZaatFiGz78mvL2wZpmSf2X8vdBJ9WPwzeQjEI4wWricSqdGL+4A
Go7YsAoK/iCx8j9+ARwnjsvGfWNyvP3DWtH4iPatCW+3DuMN2/S7g/DBb6Z4jeFWJNkjIJQ7uXQl
0VG4Ww7dAmViezsmfJDVjl2vJCf04ErySZV19If385iFCeJqeu4d/jLsMsmK0qIxNu+T8eDD+exd
9497ofj4HtH43wZcbfa/CrxHTbYH6OZA8UdbRbk1HO1dRL3MGHfVFcJbN780cOezUkwZSIBXwfV/
cTUcerpefe6gedeFAvaZEySQfecfa6sYn+3BcQp1rNso9zDDqQz/hRI2m/s54Y7mQbzQM9WZ3aSG
h3HDDcWKHj7ED6f/b4KY7zLE6Q+jiHmNI06/LUnMd1ji9EnSxHyXJ07vX0fr3v6JuGK+hyx+R4jf
njDmexnj42A+GdaY79LG6c/FG9d5zne44/TJkcd8hz1Of2b6mO/wx8eNwdPmkHmNRP4HlE+eSN4z
SZ5M1jCXgtSs0DaewQbCALHc/Pdl4x9QSwMEFAACAAgAWiBzVMoLcCfsAwAAWAkAABEAAABmaWxl
ZGxnLXNuaXBwZWQuY61WbXPaRhD+zq/YwRNb2Cpx0zYfipMZBuTiMcaMBKGu8WiEtBI3FXfq3SmY
ePzfuydBeBFN8qEabrjbvX1/dqUTxsM0jxCumBLvf33fnH+Et29hJkSKAYe/cQVLISP1O3ChbQh4
ZIOQNjwLCc1ms3ayka+HSsuUKd2c12s1pQPNQvgsWAQxSzFKEz8UaYqh9rM0CFH5GYtSZV0T8z5D
3k2TGx4LBeexiIpdo/ZSA3rWqkLBlQbGNUQYB3m60fP4BB+Key/kS0w88H3XaXdG957vFwzzdLyb
bp/oHWcwsg+oXce7Hd0PD8l3D937zviOBLyKhHvzyalQB85ocu/e2rUTTBVueP+bsRPkEYsL5mur
+Mu5YgnHqMgKK2m9W+cB5lS2Vq04sxgsqhy4mJg03+KqbZk7fmfsumTOH3uOa0PdE7FeBhKn0zsW
SqHoOJ1OGI/EUk2nnVxK5PoTSsUEn06HImUhQ8MRC6rtL++IVpRjFsj6NgLznBpvGo11jTbUScfT
sk9wgSzQc7NpGdxpXGRCBnIFBkoQE8oMX9mgBQHpGaI8I9OBRgWZFLMUF7VKppcbKPqhRLpqnW5s
2GDdtf/0h+1RDy7g5wacQ9t12w++d/OXY22Q99PHElqNRquqnJwkQKcES8l4Urq5ZHoucr3j3Nfr
JgKLwQe4bAGDq2+aoxsXF42voi97aZx0em0XipsTg3l4ORue2WcprYBWSAtpXZ7Zl6+tI5LnPF/M
UJJgqYPi/61IeSYIPsQQMUQsYXpPtkuI7sLnIM1xX2nPdbxxfwRzedQYZWcNwM1jgJgglUTwmCU+
YcKPzGSxDDzstVM2nBa2Go092f1M7GSDyvq4KehTq3KLxZbX+wO1l2HIgvRapBHKIQlNrMG437cL
BXYZng3X7b7nHFg+bn0fZEFGjRX5OWf/5OizXbSZXaPq12uFYibGDxqetN2BVR9ziaFIOPtC/a/K
+AhsJkB4kzenvL6O67vm90/F6DpSqxLuh8Ui6ndL9UOJMoqqjs4xyPxYIlpV/r7bW3RvdtTerbJd
FWrg+KxLt6Hkt0DPmQL6BSCx4CxowhX9qpYZBavj2tbWbj8bZ0wbrZ1vzjBhvFVg3rwfoeBfbfkU
M7X2f/X13OjyesNAKuwyRZ6sBsGiiNiGEqWnh5PikT3ZcFmyD9JiSnfdvuk7XWsuj4C5RM91YN7J
ZqZmxi6EudJiUSZIQSpohtGct+GNKpEU4SxPyCN/WVTiwGaZj22dTbIrxYVj2dzKREg7sdqK7dig
d1cnFQrp5VUAcIclUeeSl+e13m9M3P0vh8N5Wx0V/XUi1tPi4MPDFOFYaci919q/UEsBAj8DFAAC
AAgA+bR0VL7ejqDNAwAAIQkAACIAAAAAAAAAAAAAALSBAAAAADAwMDEtSXNSZWFjdE9TLXJlaW1w
bGVtZW50ZWQucGF0Y2hQSwECPwMUAAIACADtFHNUJe4jE/UFAABDIQAACgAAAAAAAAAAAAAAtIEN
BAAAY3N0cmxpc3QuY1BLAQI/AxQAAgAIABkWc1TJ/IKHIgUAADEYAAAKAAAAAAAAAAAAAAC0gSoK
AABjc3RybGlzdC5oUEsBAj8DFAACAAgAWiBzVMoLcCfsAwAAWAkAABEAAAAAAAAAAAAAALSBdA8A
AGZpbGVkbGctc25pcHBlZC5jUEsFBgAAAAAEAAQA/wAAAI8TAAAAAA==


--nextPart3656785.kQq0lBPeGt
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Ros-dev mailing list
[email protected]
http://reactos.org/mailman/listinfo/ros-dev

--nextPart3656785.kQq0lBPeGt--