Re: Update contributing rules and PR management

George Bişoc <[email protected]> Wed, 16 Nov 2022 09:54:52 +0000
Newsgroups gmane.os.reactos.kernel
Message-ID <[email protected]>
--===============0363765931469058750==
Content-Type: multipart/alternative;
 boundary="_=_swift_1668592492_6ebfc9f3988ad11740dd81185553558e_=_"


--_=_swift_1668592492_6ebfc9f3988ad11740dd81185553558e_=_
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

My point still stands regarding this matter as stated on PR. The newly upda=
ted contribution rules are too restrictive and this forces people who don't=
 contribute to the project with code by submitting their real name, and tha=
t's a big NO from me. I would simply propose the following suggestions:
=

1. Make such rule only mandatory for people who contribute with code;
=

2. People such as translators, artists and anyone who doesn't contribute=
 with code should be exempt from this;

3. If someone wishes to contrib=
ute to the project with code but feels uncomfortable or paranoid to submit =
their legal name, one can send a legal document declaring the reason why th=
ey shouldn't use their real name but can use a recognizable alias instead (=
we will have to think of a template if such idea ever gets through).

A=
s for the 3rd point, this can confliate with the 1st point as most people w=
ill start asking to use their alias for contributing but that's a naive spe=
culation from me. I don't know how do other FOSS projects handle this. We h=
ave productive people like I_Kill_Bugs who provides useful patches, it woul=
d be of a great bonus if we can somehow leverage the rules so that people c=
an help the project.

Regards,

George

Stas'M <binarymaster@ma=
il.ru> wrote on Tue, November 15th, 2022, 8:09 PM:

> Hello all!
>
=
> Recently I have created a Pull Request which updates the contributing rul=
es and PR management:
> https://github.com/reactos/reactos/pull/4881
>=

> This PR is a result of discussion in the chat with Joachim Henze and T=
homas Faber regarding noreply e-mails being used by some GitHub contributor=
s.
>
> It has been experimentally verified that using anonymous GitHub =
e-mail does not allow to deliver mail to the commit authors. GitHub does re=
place author's real email when `Keep my email addresses private` option is =
enabled in the account's e-mail settings.
>
> Additionally I have repla=
ced old IRC links with the references to our chat.
>
> Please send an a=
pproval review on GitHub if you are okay with the changes I made in this PR=
. Suggestions are also welcome.
>
> --
> Stas'M was here

--_=_swift_1668592492_6ebfc9f3988ad11740dd81185553558e_=_
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><head></head><body><p>My point still stands regarding this matter as =
stated on PR. The newly updated contribution rules are too restrictive and =
this forces people who don't contribute to the project with code by submitt=
ing their real name, and that's a big NO from me. I would simply propose th=
e following suggestions:</p>
<p>1. Make such rule only mandatory for people who contribute with code;</p=
>
<p>2. People such as translators, artists and anyone who doesn't contribute=
 with code should be exempt from this;</p>
<p>3. If someone wishes to contribute to the project with code but feels un=
comfortable or paranoid to submit their legal name, one can send a legal do=
cument declaring the reason why they shouldn't use their real name but can =
use a recognizable alias instead (we will have to think of a template if su=
ch idea ever gets through).</p>
<p>As for the 3rd point, this can confliate with the 1st point as most peop=
le will start asking to use their alias for contributing but that's a naive=
 speculation from me. I don't know how do other FOSS projects handle this. =
We have productive people like I_Kill_Bugs who provides useful patches, it =
would be of a great bonus if we can somehow leverage the rules so that peop=
le can help the project.</p>
<p>&nbsp;</p>
<p>Regards,</p>
<p>George</p>
<div style=3D"margin-top: 0;">Stas'M &lt;binarymaster-JGs/[email protected]&gt; wrote on =
Tue, November 15th, 2022, 8:09 PM:</div>
<div>
<blockquote style=3D"padding: 0 0.4em; border-left: #00467d 4px solid; marg=
in: 0;" cite=3D"&lt;[email protected]&gt;">
<div>Hello all!</div>
<div>&nbsp;</div>
<div>Recently I have created a Pull Request which updates the contributing =
rules and PR management:</div>
<div><a href=3D"https://github.com/reactos/reactos/pull/4881">https://githu=
b.com/reactos/reactos/pull/4881</a></div>
<div>&nbsp;</div>
<div>This PR is a result of discussion&nbsp;in the chat with Joachim Henze =
and Thomas Faber&nbsp;regarding noreply e-mails being used by some GitHub c=
ontributors.</div>
<div>&nbsp;</div>
<div>It has been experimentally verified that using anonymous GitHub e-mail=
 does not allow to deliver mail to the commit authors. GitHub does replace =
author's real email when `Keep my email addresses private` option is enable=
d in the account's e-mail settings.</div>
<div>&nbsp;</div>
<div>Additionally I have replaced old IRC links with the references to our =
chat.</div>
<div><br />Please send an&nbsp;approval review on GitHub if you are okay wi=
th the changes I made in this PR. Suggestions are also welcome.</div>
<div>&nbsp;</div>
<div>--<br />Stas'M was here</div>
</blockquote>
</div></body></html>

--_=_swift_1668592492_6ebfc9f3988ad11740dd81185553558e_=_--



--===============0363765931469058750==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Ros-dev mailing list
[email protected]
http://reactos.org/mailman/listinfo/ros-dev

--===============0363765931469058750==--