Re: DataObjectLockFree: fix facts in doxygen
Herman Bruyninckx <[email protected]>
| Newsgroups | gmane.science.robotics.orocos.devel |
|---|---|
| Message-ID | <alpine.DEB.2.02.1212111544170.24227@pma-12-013> |
On Tue, 11 Dec 2012, Sébastien Barthélémy wrote: > Hello, > > if I got it right, DataObjectLockFree advertises more than it actually does. See attached patch. Can you comment on your patch, please? Because I am a bit confused with the remarks in the patch about "too many readers", or "reading takes too long", without quantification of the "too" violations. Anyway, the Lock Free pattern has as pre-condition for its use that there are maximally N clients of the data, so that it can foresee N+1 buffer spaces of the shared data. Did you then still find problems with the code in cases where this pre-condition is satisfied? Since that would be a big bug, I guess. Or are you trying to add more robustness into the implementation in case the pre-condition is not satisfied? If so, I then think this is not the right place to realise such robustness. (The right place is at deployment, which has to guarantee/check that the pre-conditions are fulfilled.) Maybe I am completely mis-interpreting your patch, so please don't feel shy to tell me frankly :-) > -- Cheers > Sébastien Herman -- Orocos-Dev mailing list [email protected] http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev