Re: proposed patch for orogen/typegen

On Fri, Feb 1, 2013 at 3:16 PM, Peter Soetens <[email protected]> wrote:
> On Fri, Feb 1, 2013 at 2:49 PM, Peter Soetens <[email protected]> wrote:
>> On Fri, Feb 1, 2013 at 2:45 PM, Sylvain Joyeux <[email protected]> wrote:
>>> Ah AH! Now I remember why I was so puzzled.
>>>
>>> None of the git versions of typegen I looked (rock master, orocos master,
>>> orocos toolchain 2.4, 2.5 and 2.6) have this !pkg.typelist. I guess someone
>>> added it there "because it was nil" ('typelist' disappeared for quite a long
>>> time), hiding the actual bug.
>>>
>>> Where did this come from ? What version are you using ?
>>
>> Sorry, patch I made yesterday on my local copy:-) It was indeed nil,
>> so I added a check. Indeed, the check must be there since the user can
>> provide a library, in which case it may be nill.
>>
>>>
>>>
>>> Now the code is correctly generated, but I don't know if this is not
>>> obfuscating a deeper-down bug...
>>>
>>> Nope. This patch is doing the right thing. You just should not test for
>>> !empty?. Commit that to master, I'll take care of fixing -x.
>>
>> Ok, got it.
>
> https://www.gitorious.org/orocos-toolchain/orogen/merge_requests/1
>
> I created a repo clone of orogen and then a merge request... It would
> have been more convenient to clone rock-orogen, then you could see two
> more patches regarding TAO/OMNIORB cmake fixes...
>
> I could also merge rock-orogen/master into orogen/master if you
> consider it stable...ie the other way around.
>
> I omitted the OROCOS_TARGET stuff.

Ping ? Can we / you merge this ?

Peter
-- 
Orocos-Dev mailing list
[email protected]
http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev