Re: potential fix for updateHook / event port callbacks called too often
Peter Soetens <[email protected]> Wed, 22 Oct 2014 10:32:38 +0200
| Newsgroups | gmane.science.robotics.orocos.devel |
|---|---|
| Message-ID | <CAMYDobW5YogAovXcxbSgHKjysM1TgX9CLFCsymoZ7jWzvjcM2Q@mail.gmail.com> |
On Tue, Oct 21, 2014 at 4:42 PM, Peter Soetens <[email protected]> wrote: > > Hi all, > > After a discussion with Johannes, we figured out a way to solve this long standing issue > (all info here: https://github.com/orocos-toolchain/rtt/issues/70 ) and I implemented a small patch that solves this gracefully. The discussion is mainly going on at the above link, but I just converted it to a pull request with hub : $ hub pull-request -b orocos-toolchain:master -h psoetens:master-update-hook-called-too-much https://github.com/orocos-toolchain/rtt/issues/70 https://github.com/orocos-toolchain/rtt/pull/70 Warning: Issue to pull request conversion is deprecated and might not work in the future. which also allows travis to cross-check any patches we're proposing. I'm not proposing to merge yet, it's just for tracking purposes. The patch does not influence the behavior of FileDescriptorActivity. Someone should probably look deeper into that if this is ok or not. > > The patch referenced in the github issue is probably not the end-point, but we're very close. It should still be integrated with the master/slave work which is going on, and probably kick out the child engine code for a matter of cleanup (not required though). Peter -- Orocos-Dev mailing list [email protected] http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev