Re: WIN32 compilation issues patch

Paul Osmialowski <[email protected]>
Newsgroups gmane.science.robotics.playerstage
Message-ID <[email protected]>
Hi Jorge,

Your patch is great even if it has some surprising places (for 
example, removes inclusion of stdlib.h in imageseq.cc - fortunately, I 
can't see any reason for this inclusion in whole imageseq code, so it is 
acceptable). Other thing is your SIGQUIT definition in playerv.c: if win 
api does not define that, it means it does not support that, so it 
shouldn't be done like that. More portable and system independent 
solution is:
#ifdef SIGINT
   signal(SIGINT, sig_quit);
#endif
#ifdef SIGQUIT
   signal(SIGQUIT, sig_quit);
#endif

If you're able to compile imageseq.cc driver it means you've managed with 
opencv integration with player. How did you do that? Did you install 
pkgconfig for windows? (there's a pkg-config.exe binary available for 
download, however opencv for Windows does not provide opencv.pc file, did 
you prepare one for your own? how?! I couldn't manage with that). Did you 
managed with compilation of my cvcam driver too?

Did you integrate libjpeg for windows with Player? (for cameracompress 
driver). Is it though problem?

Paul


On Mon, 26 Apr 2010, Jorge Santos Simón wrote:

> Hello all,
>
> I have prepared a patch with all the modifications I have done to
> player code to successfully compile on windows with Visual Studio
> 2008.
> All modifications should be innocuous for Linux compilation, as they
> are all included on precompiler directives of kind:
>
> #if defined WIN32
>  ...include some files...
>  ...defines missing on windows...
> #else
>  ...include some others...
> #endif
>
> In fact, I have successfully compiled my code on Linux.
>
> I hope the path will work with no problems....  is the first time I
> use patch generation tools (by the way, I have used tortoise SVN).
> I have tried it on Linux and it works fine for me.
>
> Best regards,
> Jorge
>

------------------------------------------------------------------------------

_______________________________________________
Playerstage-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/playerstage-developers
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.