Re: Strange crash in Player server

I agree with this. When I wrote the CMake build system, moving the 
driver Makefiles across was not so straight-forward, as it required 
knowledge of everything in the drivers. So I just copied what the 
Makefiles did in CMake. :)

There is definitely a benefit to centralising the more common ones, such 
as JPEG. It should speed up the initial configure step a bit.

Geoff

On 04/07/10 04:34, Rich Mattes wrote:

> As a side observation, is it really necessary to perform the same check
> for opencv.pc, jpeglib.h, etc. for every driver that requires them?
> Can't we just look for stuff once in SearchForStuff.cmake and consult
> variables like JPEG_FOUND or OPENCV_FOUND?  To cite an example,
> OpenCV.pc is checked at least four times by
> PLAYERDRIVER_REQUIRE_PACKAGE.  Further, PLAYERDRIVER_REQUIRE_HEADER
> (jpeglib.h) is called at least four times (cameracompress,
> cameradecompress, imagecmp, camfilter, etc) inside an IF (HAVE_JPEG)
> statement.  Considering one of the tests for HAVE_JPEG is
> CHECK_INCLUDE_FILES("stdio.h;jpeglib.h" HAVE_JPEGLIB_H), I'm wondering
> what the utility of the extra REQUIRE_HEADER call is.  I guess the
> current way lets people keep their driver CMakeLists.txt comprehensive
> and lets people add drivers without digging deep into Player's
> buildsystem, but I think it might be worth it to centralize checks for
> some of the more common packages.

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first