(Possibly) hdf_copy bug

Hello, everybody.

I've just found that the hdf_copy does copy links in a useless way. I.e. it
does copy node value (link text), but does not copy the "link" flag.

Of course this could be a feature, but a useless one. So wouldn't it be
better to make following modification (revision number is from our internal
repository)?

---:<---
--- util/neo_hdf.c      (revision 38710)
+++ util/neo_hdf.c      (working copy)
@@ -1042,7 +1042,7 @@
   {
     err = _copy_attr(&attr_copy, st->attr);
     if (err) return nerr_pass(err);
-    err = _set_value(dest, st->name, st->value, 1, 1, 0, attr_copy, &dt);
+    err = _set_value(dest, st->name, st->value, 1, 1, st->link, attr_copy, &dt);
     if (err) {
       _dealloc_hdf_attr(&attr_copy);
       return nerr_pass(err);
--->:---

This would copy the link flag too, and, therefore, preserve the link.

Thank you for your attention :)

Sincerely,
Nikolai



 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/ClearSilver/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/ClearSilver/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:[email protected] 
    mailto:[email protected]

<*> To unsubscribe from this group, send an email to:
    [email protected]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/