One more links-related _set_value bug

Nikolai Kondrashov <[email protected]>
Newsgroups gmane.text.clearsilver.general
Message-ID <[email protected]>
Hello, All.

It looks like I've stumbled upon one more links-related _set_value bug. When
using hdf_set_symlink(hdf, NULL, target) to make node itself a link, it does
not become one. Instead it only sets it's value to the link path.

This is due to missing "link" flag transfer in the NULL-name case handling
in the _set_value function. Below is a patch for 0.10.4 (I'm still
struggling importing new release into our repository/build system) but it
works on 0.10.5.

---:<---
--- util/neo_hdf.c      (revision 41760)
+++ util/neo_hdf.c      (working copy)
@@ -599,6 +599,9 @@
     {
       _merge_attr(hdf->attr, attr);
     }
+    /* set link flag */
+    if (link) hdf->link = 1;
+    else hdf->link = 0;
     /* if we're setting ourselves to ourselves... */
     if (hdf->value == value)
     {
--->:---

Thanks :)

Sincerely,
Nick


 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/ClearSilver/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/ClearSilver/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:[email protected] 
    mailto:[email protected]

<*> To unsubscribe from this group, send an email to:
    [email protected]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.