Re: One more links-related _set_value bug

Can't believe its taken me this long to get to this, but I've checked in
your fix.

Brandon

On 08/03/07 Nikolai Kondrashov uttered the following other thing:
> Hello, All.
> 
> It looks like I've stumbled upon one more links-related _set_value bug. When
> using hdf_set_symlink(hdf, NULL, target) to make node itself a link, it does
> not become one. Instead it only sets it's value to the link path.
> 
> This is due to missing "link" flag transfer in the NULL-name case handling
> in the _set_value function. Below is a patch for 0.10.4 (I'm still
> struggling importing new release into our repository/build system) but it
> works on 0.10.5.
> 
> ---:<---
> --- util/neo_hdf.c      (revision 41760)
> +++ util/neo_hdf.c      (working copy)
> @@ -599,6 +599,9 @@
>      {
>        _merge_attr(hdf->attr, attr);
>      }
> +    /* set link flag */
> +    if (link) hdf->link = 1;
> +    else hdf->link = 0;
>      /* if we're setting ourselves to ourselves... */
>      if (hdf->value == value)
>      {
> --->:---
> 
> Thanks :)
> 
> Sincerely,
> Nick
> 
> 
>  
> Yahoo! Groups Links
> 
> 
> 

-- 
  "The rule is, jam to-morrow and jam yesterday, but never jam today."
        -- Lewis Carroll
                                           http://www.fiction.net/blong/