[docutils:bugs] #500 Html5WriterPublishPartsTestCase.test_publish skips too much when with_pygments is False

Günter Milde via Docutils-develop <[email protected]> Tue, 20 May 2025 15:09:58 -0000
Newsgroups gmane.text.docutils.devel
Message-ID </p/docutils/bugs/500/495093e955bda11fd332bc9760276bfc0e8c1607.bugs@docutils.p.sourceforge.net>
- **status**: open --> open-fixed
- **Comment**:

Thanks for the fast feedback. The patch is now in the repository [r10135].



---

**[bugs:#500] Html5WriterPublishPartsTestCase.test_publish skips too much when with_pygments is False**

**Status:** open-fixed
**Created:** Mon May 19, 2025 10:15 AM UTC by Michał Górny
**Last Updated:** Tue May 20, 2025 12:24 PM UTC
**Owner:** nobody


While debugging something else, I've noticed that the `Html5WriterPublishPartsTestCase.test_publish()` case contains the following bit:

```
        for name, (settings_overrides, cases) in totest.items():
            if name == 'syntax_highlight' and not with_pygments:
                self.skipTest('syntax highlight requires pygments')
```

This means that if `with_pygments` is `False`, all the remaining cases from `totest` are skipped. If I replace it with:

```
        for name, (settings_overrides, cases) in totest.items():
            if name == 'syntax_highlight' and not with_pygments:
                continue
```

I see some test regressions too.


---

Sent from sourceforge.net because [email protected] is subscribed to https://sourceforge.net/p/docutils/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/docutils/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.