Re: don't put closing parenthesis on its own line

John Scipione <[email protected]> Wed, 27 Feb 2013 15:22:48 -0500
Newsgroups gmane.text.doxygen.devel
Message-ID <CAOoW638PWJrDXJmXizKAx-cgcY+zbb34RAh+Eah9=kQsEmA1Ww@mail.gmail.com>
On Tue, Feb 26, 2013 at 2:32 AM, Anthony Foiani
<[email protected]> wrote:
> Greetings.
>
> I don't know if it is intentional or not, but I found that the current
> Doxygen output for multiple (2-or-more) argument functions to be
> sub-optimal.  It wants to render it like so:
>
> retType
> myFunction( Type1 arg1,
>           Type2 arg2
>           )
>
> In case that formatting gets mangled, you can see the difference in
> this sample page, pointed out by PovAddict:
>
>    http://www.stack.nl/~dimitri/doxygen/manual/examples/overload/html/class_test.html
>    or: http://preview.tinyurl.com/avovthd
>
> I don't see any reason for this extra space, not even "const" or
> similar.  After all, 0- and 1-arity functions don't get the extra
> space.

Hey there, perhaps in some cases the extra space is not needed, but,
in others it adds something. Here is an example from the heavily
customized but Doxygen-generated docs of my project (Haiku):

http://api.haiku-os.org/classBArchivable.html#a256d5d912ec4e9a44be9054ee4d925f0

It looks fine in this case to have the extra space and lines up the
const with the parameter name instead of the parameter type.

If you really want this to work though you'd need to add a colspan="2"
to that ending <td> for only the last parameter. It would look like
this:

+    t << "          <td colspan=\"2\">";

So that the const, virtual, etc. specifiers would span both the param
type and param name columns. Make that change and I could get behind
this patch.

Thanks,
John Scipione

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb