doxygen-1.8.5:doxygen.cpp:3572: possible bad if test ?

David Binderman <[email protected]> Tue, 17 Dec 2013 19:20:24 +0000
Newsgroups gmane.text.doxygen.devel
Message-ID <[email protected]>
Hello there,

I just ran the static analyser "cppcheck" over the source
code of doxygen-1.8.5. It said many things, including

[doxygen.cpp:3572]: (warning) Logical conjunction always evaluates to false: EXPR != -1 && EXPR == -1.

Source code is

if (md->getStartBodyLine()!=-1 && md->getStartBodyLine()==-1)

Suggest code rework.

The analyser also said

[fortranscanner.cpp:1307]: (style) Array index 'i' is used before limits check.
[markdown.cpp:541]: (style) Array index 'i' is used before limits check.
[markdown.cpp:1317]: (style) Array index 'i' is used before limits check.
[markdown.cpp:1323]: (style) Array index 'i' is used before limits check.

which may also be worth fixing.

Regards

David Binderman 		 	   		  
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk