Re: [PATCH] graphviz bugfix broke doxygen

Hello,

It's a good thing that you are submitting patches to the developer list,
and we appreciate you submitting your patches.  However, we prefer all
bugs to be filed within the bugzilla, even if you have the patches to
fix the bugs.  Doing so makes it easier for us to add fixed bugs to the
ChangeLogs, and make better use of bugzilla reports. :)

As a courtesy, I imported the patch into the bugzilla for you:

http://bugzilla.gnome.org/show_bug.cgi?id=333270

Thank you,

- KJM

John Ellson wrote:
> 
> There is a change in the Postscript output of dot from 
> graphviz-2.9.20060302.0540 (and later) to use %%BoundingBox: (atend) 
> so as to properly support multiple graphs in a single PostScript file
>  according to page 39 of: 
> http://partners.adobe.com/public/developer/en/ps/5001.DSC_Spec.pdf
> 
> Unfortunately this breaks doxygen which expects the first 
> %%BoundingBox: record to contain the coordinates.
> 
> To fix this in a backward compatible way I suggest that doxygen 
> should use the %%PageBoundingBox instead.
> 
> John
> 
> 
> 
> Index: src/dot.cpp 
> =================================================================== 
> RCS file: /cvsroot/doxygen/src/dot.cpp,v retrieving revision 1.107 
> diff -r1.107 dot.cpp 277c277 <     if (strncmp(buf,"%%BoundingBox: 
> ",15)==0) ---
>> if (strncmp(buf,"%%PageBoundingBox: ",19)==0)
> 280c280 <       if (sscanf(buf,"%%%%BoundingBox: %d %d %d 
> %d",&x,&y,width,height)!=4) ---
>> if (sscanf(buf,"%%%%PageBoundingBox: %d %d %d
> %d",&x,&y,width,height)!=4)
> 
> 
> 
> 
> 
> 
> ------------------------------------------------------- This SF.Net 
> email is sponsored by xPML, a groundbreaking scripting language that 
> extends applications into web and mobile media. Attend the live 
> webcast and join the prime developer group breaking into this new 
> coding territory! 
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
>  _______________________________________________ Doxygen-develop 
> mailing list [email protected] 
> https://lists.sourceforge.net/lists/listinfo/doxygen-develop
> 


-- 
This message has been digitally signed with a GlobalSign-issued certificate.
For more information, please visit GlobalSign's web site at:
http://www.globalsign.net/