Some thoughts about packaging and compilation...

Hi Stéphane,

Stéphane Téletchéa writes:
 > 	b) i add the 'status' option in the cases (not sure this is completely 
 > portable), and correct the *) case since it misses some existing options:
 > 
 > Original:
 >       *)
 > -       echo "Usage: $(basename $0) {start|stop}" >&2
 > -       exit 1;;
 > Corrected:
 > 
 > +       echo "Usage: $(basename $0) 
 > {start|stop|status|restart|force-reload}" >&2
 > +       RETVAL 1
 > +       ;;
 > 
 > In your provided script, the options restart and force-reload are 
 > mentionned so i presume this is a good thing to indicate it in the Usage 
 > line. (do not bother about the RETVAL 1, this is exactly the same as 
 > exit 1).
 > 

I've added restart and force-reload to the usage message. What is
"status" supposed to do?

 > 3 - some permissions seem incorrect:
 > -rwxr-xr-x  1 steletch mig  1403 avr 14 00:07 AUTHORS*
 > -rwxr-xr-x  1 steletch mig 29746 avr 14 00:07 COPYING*
 > -rwxr-xr-x  1 steletch mig  2964 jun 25 23:38 INSTALL*
 > -rwxr-xr-x  1 steletch mig 10280 avr 14 00:07 missing*
 > -rwxr-xr-x  1 steletch mig 30690 jun 25 15:39 NEWS*
 > -rwxr-xr-x  1 steletch mig  8876 mai 26 15:47 README*
 > -rw-r--r--  1 steletch mig 12660 mai 27 23:18 UPGRADING
 > 
 > All of these should be 644 instead of 755 (no executable bit ...) since 
 > they are only texty files ;-).
 > 

I'm sorry that you had to bug me so long to make me fix it. This does
not mean that I only fix bugs that make their way into the bug tracker
:-) I was simply too busy updating my laptop during the past days.

 > Those are details but since i cannot help much in coding, i try to get 
 > some feedback on little things ;-)
 > 

Your input is much appreciated. For a programmer other stuff may
always appear more important, but these pesky details often affect the
user experience more than a serious bug that occurs only once in a
while. Don't hesitate to mention these annoyances, as unimportant as
they may seem.

regards,
Markus

-- 
Markus Hoenicka
[email protected]
(Spam-protected email: replace the quadrupeds with "mhoenicka")
http://www.mhoenicka.de


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642