Re: Re: [Rlib-devel] BIG NEWS

Hi 

Thanks for the patch!

I applied the patch minus the "r->queries_count = 0;" because the struct
is bzero'd when its initialized.

It also motivated me to fix a few other crashing situations if the
actual query failed to run.

Curiosity question.  What would php compiler folks be doing w/ RLIB?

- bob

On Fri, 2005-03-04 at 14:04 -0500, Shannon Weyrick wrote:
> Bob Doan wrote:
> 
> >Hey all,
> >
> >I have written a GPL'd PDF library for RLIB called RPDF.  It will now be
> >distributed w/ RLIB as the default PDF LIBRARY and CPDF is OFFICIAL
> >REMOVED FROM RLIB!!!
> >
> >Bonuses: Don't have to worry about cpdf any more
> >RLIB is now 100% GPL'D
> >
> >It may not be production ready yet.  It needs some testing.  If you have
> >a change could you try it and see if it works and report back 
> >
> >download it here:
> >
> >http://www.sicom.com/~bdoan/rlib-1.3.2.tar.gz
> >
> >THIS IS NOT THE OFFICIAL 1.3.2 Release!!!! 
> >
> >Please try it.. I want to know if it works for you all!
> >
> >Thanks!
> >
> >- bob
> >
> >
> >  
> >
> Hi Bob,
> 
> Congrats on the new PDF library, seems to work well so far. I just 
> started using RLIB and I'm really impressed so far - thanks for your 
> efforts on it.
> 
> On another note, I was experiencing a segfault which I tracked down to 
> not passing a query to a report (via rlib_add_query_as) before running 
> rlib_execute. I whipped up a patch (attached) that at least handles this 
> a little more gracefully.
> 
> Thanks again,
> Shannon
> 
> plain text document attachment (no_query_fix.diff)
> --- rlib-1.3.2/libsrc/api.c	2005-03-02 09:46:41.000000000 -0500
> +++ rlib-1.3.2-weyrick/libsrc/api.c	2005-03-04 13:53:25.980009365 -0500
> @@ -68,6 +68,7 @@
>  	
>  	r->output_parameters = g_hash_table_new_full (g_str_hash, g_str_equal, string_destroyer, string_destroyer);
>  	r->input_metadata = g_hash_table_new_full (g_str_hash, g_str_equal, string_destroyer, metadata_destroyer);
> +	r->queries_count = 0;
>  	
>  #if !DISABLE_UTF8
>  	make_all_locales_utf8();
> @@ -161,6 +162,11 @@
>  	char newfile[MAXSTRLEN];
>  
>  	r->now = time(NULL);
> +	
> +	if(r->queries_count < 1) {
> +		r_error("No queries added to report\n");
> +		return -1;	
> +	}
>  	rlib_execute_queries(r);
>  
>  	LIBXML_TEST_VERSION



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click