[jira] [Commented] (BATIK-1221) Inconsistent method name

    [ https://issues.apache.org/jira/browse/BATIK-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446940#comment-16446940 ] 

ASF GitHub Bot commented on BATIK-1221:
---------------------------------------

GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/batik/pull/14

    BATIK-1221: Inconsistent method name

    Change the method name "convertOverflow" to "isOverflow".

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/batik trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/batik/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14
    
----
commit adf693186cadcc124bbd3d03df65e027ae228d27
Author: Kui LIU <brucekuiliu@...>
Date:   2018-04-21T18:59:34Z

    Change the method name "convertOverflow" to "isOverflow".

----


> Inconsistent method name
> ------------------------
>
>                 Key: BATIK-1221
>                 URL: https://issues.apache.org/jira/browse/BATIK-1221
>             Project: Batik
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is names as "convertOverflow", but the method does convert any 'Overflow' but just checks whether the element 'e' is overflow or not.
> Thus, the method name should be "isOverflow".
> {code:java}
>  public static boolean convertOverflow(Element e) {
>         Value v = getComputedStyle(e, SVGCSSEngine.OVERFLOW_INDEX);
>         String s = v.getStringValue();
>         return (s.charAt(0) == 'h') || (s.charAt(0) == 's');
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)