[jira] [Commented] (BATIK-1249) batik sub jars does not adhere to the java 11 module system

    [ https://issues.apache.org/jira/browse/BATIK-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730373#comment-16730373 ] 

ASF GitHub Bot commented on BATIK-1249:
---------------------------------------

GitHub user aanno opened a pull request:

    https://github.com/apache/batik/pull/17

    BATIK-1249: batik sub jars does not adhere to the java 11 module system

    If you use the batik sub jars (i.e. all batik jars except batik-all) with java 11 you will get the following compile error:
    
    ```
    error: the unnamed module reads package org.w3c.dom.events from both java.xml and batik.ext
    error: the unnamed module reads package org.apache.batik.util from both batik.util and batik.constants
    ```
    
    This is because the jars share some (java class) code in the same packages.
    
    The new java 11 (or java 9) module system does not like this kind of 'split jars'. The agreed-upon long-term solution to split jars is to separate the package namespaces. This is what I did. In detail:
    
    *  I moved `org.apache.batik.util.XMLConstants` (of `batik-constants.jar`) to its one package (`org.apache.batik.constants.XMLConstants`). This way, it does not clash with `batik-util.jar`.
    * I removed all of `batik-ext/src/main/java/org/w3c/dom/events` as these classes are part of (at least) Java 8 and up. Hence they clash with internal classes and would spoil the module system usage.
    * Compilation is now for Java 8 (as Java 6 and Java 7 are long gone and not supported any more). 
    
    I would be glad it you could consider integration into branch master.
    
    Kind regards,
    
    aanno


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aanno/batik feature/pr-batik-1249-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/batik/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit 5778eb4c48c47684fd681ab1c55f4553ac54239f
Author: Thomas Pasch <thomas.pasch@...>
Date:   2018-12-28T16:39:04Z

    initial commit

----


> batik sub jars does not adhere to the java 11 module system
> -----------------------------------------------------------
>
>                 Key: BATIK-1249
>                 URL: https://issues.apache.org/jira/browse/BATIK-1249
>             Project: Batik
>          Issue Type: Bug
>            Reporter: Thomas Pasch
>            Priority: Major
>
> If you use the batik sub jars (i.e. all batik jars except batik-all) with java 11 you will get the following compile error:
> ```
> error: the unnamed module reads package org.w3c.dom.events from both java.xml and batik.ext
> error: the unnamed module reads package org.apache.batik.util from both batik.util and batik.constants
> ```
> This is because the jars share some (java class) code in the {{same}} packages.
> The new java 11 (or java 9) module system does not like this kind of 'split jars'. The agreed-upon long-term solution to split jars is to separate the package namespaces.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)