[launcher] Moving to a 1.0 release (was Re: [Launcher] Requested change in Launcher.getBootstrapFile)

Any issues concerning this patch?
If not I will apply this change in a day or two.

Also shouldn't a launcher get a proper 1.0 release?
This minor issue is the first one I see and this component is in 
commons over 16 months.
So I propose to apply this patch and then proceed with a 1.0 release.

Comments? (volunteers to help testing the release candidate?)
Tomcat guys, what do you think?

-- Dirk


[email protected] wrote:
> Hi,
> I am trying to use the Launcher from a class running in a WAS 5.0 Web App.
> 
> I ran into a problem when the Launcher.start is trying to get the Bootstrap
> File for use in determining the canonical path for its default launch file.
> 
> The problem is that the code
> 	boolean isJar = "jar".equals(resource.getProtocol()) ? true : false;
> 
> Does not evaluate to true when running in the WAS Web App.  The reason is
> that the protocol returned is "wsjar".
> 
> I would like to suggest changing the above line of code to:
> 	boolean isJar = (resource.getProtocol().indexOf("jar") >= 0) ? true
> : false;
> 
> Marcus Mosttler