Re: [Axis2][Axiom] Proposal to change the OMBuilder interface

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

First apologies for not observing JIRAs. I just added a comment to that.

Well, what I can not understand is what a URL and a content type have to
do with an XML builder. Please remember that OMBuilder is a generic XML
object model builder.

I prefer if you handle non-XML things outside of this builder or even
write a new builder extending OMBuilder.

- From the information I got from this mail and the JIRA, I don't think I
agree with this proposal.

Keith, can you please be kind enough to explain a bit more on this as I
feel I am missing something here.

Thanks,
Chinthaka

Thilina Gunarathne wrote:
> Hi all,
> As requested in the AXIS2-2213 I would like to change the method
> signature of the  init method in the OMBuilder  as follows.
> 
> public void init(InputStream inputStream, String charSetEncoding,
> String url, String contentType)
> 
> URL will be useful when building an OM from query parameters. Also the
> content-type will be useful to find the boundary value when handling a
> boundary delimited message... This will be useful for
> multipart/form-data as well as for the MIME..
> 
> With the above change we'll be able to move the MIME builder creation
> logic in to builders.. In order to make it possible I would like to
> add a getAttachments() method to the OMBuilder.
> 
> Thanks,
> Thilina

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF2+VEjON2uBzUhh8RAh1HAKCeY23bA9X/+Z/dAJJvOyPxeIiYhACfZb9o
vzlJ+p0831khW9XuYSjFl8M=
=foMg
-----END PGP SIGNATURE-----