Re: [axiom] [axis2] Coding style

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Glen Daniels wrote:
> Hey folks:
> 
> Quick code commentary....
> 
> Here's some code starting at line 85 in SOAP12FaultImpl:
> 
>     public void setReason(SOAPFaultReason reason) throws
> SOAPProcessingException {
>         if (!(reason instanceof SOAP12FaultReasonImpl)) {
>             throw new SOAPProcessingException(
>                     "Expecting SOAP 1.2 implementation of SOAP Fault
> Reason. " +
>                     "But received some other implementation");
>         }
>         super.setReason(reason);
>     }
> 
> Two comments here.
> 
> 1) Messages should be internationalized and accessed via resource APIs.
>  Really.  At some point we should all stop working on features and take
> a few days to hang out and make a serious push to do this across the
> board.  After that's done we should implement a daily automated scan
> (like Axis1 does on each build) across the source to alert us of
> non-internationalized messages.

Glen, thanks for owning the process of I18N'ing everything. This was in
our todo list for a long time but no one had a chance to do it. I hope
you are the best person for that ;)

> 
> 2) When generating exceptions like this, it really isn't very useful to
> say "received some other implementation" or "value wasn't what was
> expected".  It's much more helpful to actually put the problem value
> into the exception.... In this case it only takes an extra moment to code
> 
>    "but received " + reason.getClass() + "."


1000 appologies for this code written by me some time back. Won't happen
again :(.

- -- Chinthaka
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF7icIjON2uBzUhh8RAhPmAJ4xV0Df9D9shgIzXDoer/lFZLbDTACdFIr1
S0JkiJs+VFx59poGIALOIxU=
=gY6q
-----END PGP SIGNATURE-----