[ expat-Bugs-1498374 ] runtests.cpp does not compile

Bugs item #1498374, was opened at 2006-05-31 13:51
Message generated for change (Comment added) made by kwaclaw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=1498374&group_id=10127

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build control
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: runtests.cpp does not compile

Initial Comment:
The Makefile of the test directory includes -I./lib
and not -I../lib  for expat.h and expat_external.h

If there is no installed copy of the .h filesn compile
of runtests.c doesn't work. 

Looks like the Makefile.in is not correct. 

[email protected]

----------------------------------------------------------------------

>Comment By: Karl Waclawek (kwaclaw)
Date: 2009-01-17 13:29

Message:
Seems this was fixed by another issue's fix.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-05-28 07:06

Message:
Logged In: NO 

The following change (as pointed by
http://sourceforge.net/tracker/index.php?func=detail&aid=1597115&group_id=10127&atid=110127)
works for me:

--- expat-2.0.0/Makefile.in.old 2007-05-28 10:58:17.000000000 +0000
+++ expat-2.0.0/Makefile.in     2007-05-28 10:48:18.000000000 +0000
@@ -107,7 +107,7 @@
 
 INCLUDES = -I$(srcdir)/lib -I.
 LDFLAGS = @LDFLAGS@
-CPPFLAGS = @CPPFLAGS@
+CPPFLAGS = @CPPFLAGS@ $(INCLUDES) $(DEFS)
 CFLAGS = @CFLAGS@ -DHAVE_EXPAT_CONFIG_H
 VSNFLAG = -version-info @LIBCURRENT@:@LIBREVISION@:@LIBAGE@
 


----------------------------------------------------------------------

Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2006-07-01 11:59

Message:
Logged In: YES 
user_id=3066

There is no Makefile in the tests/ directory; the top-level
Makefile is responsible for building the tests.  When that
runs, the top-level directory should be the current
directory, so ./lib is the right path for the includes.

Unfortunately, I don't have access to a machine that doesn't
have at least some version of Expat installed by the base
system, so I'll leave this open until I have a chance to run
that test to confirm.

----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2006-05-31 13:56

Message:
Logged In: YES 
user_id=290026

I think Fred needs something to do. ;-)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=1498374&group_id=10127