CMake build problems with expat 2.1.0 and a patch to fix them

--f46d042a0d619e332604d4014b97
Content-Type: multipart/alternative; boundary=f46d042a0d619e331204d4014b95

--f46d042a0d619e331204d4014b95
Content-Type: text/plain; charset=ISO-8859-1

Hi,

I ran into the following problems while trying to build expat 2.1.0 with
CMake:

* I couldn't set the directories for man pages and libraries. Some Linux
distros such as
Slackware put the man pages in /usr/man instead of /usr/share/man and on
x86_64
libs go into /usr/lib64. It's useful when you can override the defaults
from the command
line like:

cmake -DMAN_INSTALL_DIR=PATH:"/usr/man" -DLIB_INSTALL_DIR=PATH:"/usr/lib64"

So I made all this configurable instead of being hardcoded.

* The pkgconfig file was not generated correctly for /usr/lib64 since it
was hardcoding /usr/lib.
Also it's nice when you can set the include dir so you can put the headers
in /usr/include/expat for example. The exec_prefix is not 'bin', I don't
know what it's used for, but all .pc files I have ever seen just set it to
${prefix}. So it seems safe to do that here too.

* xmlwf couldn't be built because the compiler couldn't write the xmlwf
executable at the root
of the source because there was already a directory named xmlwf. The
solution to that was to
make another CMakeLists.txt inside the xmlwf directory with the part about
building it.

* The expat shared library wasn't built with the usual sonames. So I fixed
that too.

I hope you will find my patch helpful.

Regards,

C. Thompson

--f46d042a0d619e331204d4014b95
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><span style=3D"font-family:arial,sans-serif;font-size:13px=
">Hi,</span><div style=3D"font-family:arial,sans-serif;font-size:13px"><br>=
</div><div style=3D"font-family:arial,sans-serif;font-size:13px">I ran into=
 the following problems while trying to build expat 2.1.0 with CMake:</div>
<div style=3D"font-family:arial,sans-serif;font-size:13px"><br></div><div s=
tyle=3D"font-family:arial,sans-serif;font-size:13px">* I couldn&#39;t set t=
he directories for man pages and libraries. Some Linux distros such as</div=
>
<div style=3D"font-family:arial,sans-serif;font-size:13px">Slackware put th=
e man pages in /usr/man instead of /usr/share/man and on x86_64</div><div s=
tyle=3D"font-family:arial,sans-serif;font-size:13px">libs go into /usr/lib6=
4. It&#39;s useful when you can override the defaults from the command</div=
>
<div style=3D"font-family:arial,sans-serif;font-size:13px">line like:</div>=
<div style=3D"font-family:arial,sans-serif;font-size:13px"><br></div><div s=
tyle=3D"font-family:arial,sans-serif;font-size:13px">cmake -DMAN_INSTALL_DI=
R=3DPATH:&quot;/usr/man&quot; -DLIB_INSTALL_DIR=3DPATH:&quot;/usr/lib64&quo=
t;</div>
<div style=3D"font-family:arial,sans-serif;font-size:13px"><br></div><div s=
tyle=3D"font-family:arial,sans-serif;font-size:13px">So I made all this con=
figurable instead of being hardcoded.</div><div style=3D"font-family:arial,=
sans-serif;font-size:13px">
<br></div><div style=3D"font-family:arial,sans-serif;font-size:13px">* The =
pkgconfig file was not generated correctly for /usr/lib64 since it was hard=
coding /usr/lib.</div><div style=3D"font-family:arial,sans-serif;font-size:=
13px">
Also it&#39;s nice when you can set the include dir so you can put the head=
ers in /usr/include/expat for example. The exec_prefix is not &#39;bin&#39;=
, I don&#39;t know what it&#39;s used for, but all .pc files I have ever se=
en just set it to ${prefix}. So it seems safe to do that here too.</div>
<div style=3D"font-family:arial,sans-serif;font-size:13px"><br></div><div s=
tyle=3D"font-family:arial,sans-serif;font-size:13px">* xmlwf couldn&#39;t b=
e built because the compiler couldn&#39;t write the xmlwf executable at the=
 root</div>
<div style=3D"font-family:arial,sans-serif;font-size:13px">of the source be=
cause there was already a directory named xmlwf. The solution to that was t=
o</div><div style=3D"font-family:arial,sans-serif;font-size:13px">make anot=
her CMakeLists.txt inside the xmlwf directory with the part about building =
it.</div>
<div style=3D"font-family:arial,sans-serif;font-size:13px"><br></div><div s=
tyle=3D"font-family:arial,sans-serif;font-size:13px">* The expat shared lib=
rary wasn&#39;t built with the usual sonames. So I fixed that too.</div><di=
v style=3D"font-family:arial,sans-serif;font-size:13px">
<br></div><div style=3D"font-family:arial,sans-serif;font-size:13px">I hope=
 you will find my patch helpful.</div><div style=3D"font-family:arial,sans-=
serif;font-size:13px"><br></div><div style=3D"font-family:arial,sans-serif;=
font-size:13px">
Regards,<br><br>C. Thompson</div></div>

--f46d042a0d619e331204d4014b95--
--f46d042a0d619e332604d4014b97
Content-Type: application/octet-stream; name="expat-2.1.0-cmakefixes.patch"
Content-Disposition: attachment; filename="expat-2.1.0-cmakefixes.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_hcbemf2w0

ZGlmZiAtciAtdSAtTiBleHBhdC0yLjEuMC9DTWFrZUxpc3RzLnR4dCBleHBhdC0yLjEuMC1jbWFr
ZWZpeGVzL0NNYWtlTGlzdHMudHh0Ci0tLSBleHBhdC0yLjEuMC9DTWFrZUxpc3RzLnR4dAkyMDEy
LTAzLTA1IDE1OjM4OjIyLjAwMDAwMDAwMCArMDEwMAorKysgZXhwYXQtMi4xLjAtY21ha2VmaXhl
cy9DTWFrZUxpc3RzLnR4dAkyMDEzLTAxLTI0IDA1OjAwOjU3LjY3NDAwNTQ3NCArMDEwMApAQCAt
MTAsNiArMTAsMzAgQEAKIHNldChQQUNLQUdFX1NUUklORyAiJHtQQUNLQUdFX05BTUV9ICR7UEFD
S0FHRV9WRVJTSU9OfSIpDQogc2V0KFBBQ0tBR0VfVEFSTkFNRSAiJHtQQUNLQUdFX05BTUV9IikN
CiANCitzZXQoTUFKT1IgIjEiKQ0KK3NldChNSU5PUiAiNiIpDQorc2V0KFBBVENIICIwIikNCisN
CitpZihOT1QgREVGSU5FRCBCSU5fSU5TVEFMTF9ESVIpDQorc2V0KEJJTl9JTlNUQUxMX0RJUiAk
e0NNQUtFX0lOU1RBTExfUFJFRklYfS9iaW4pDQorZW5kaWYoTk9UIERFRklORUQgQklOX0lOU1RB
TExfRElSKQ0KKw0KK2lmKE5PVCBERUZJTkVEIE1BTl9JTlNUQUxMX0RJUikNCitzZXQoTUFOX0lO
U1RBTExfRElSICR7Q01BS0VfSU5TVEFMTF9QUkVGSVh9L3NoYXJlL21hbikNCitlbmRpZihOT1Qg
REVGSU5FRCBNQU5fSU5TVEFMTF9ESVIpDQorDQoraWYoTk9UIERFRklORUQgTElCX0lOU1RBTExf
RElSKQ0KK3NldChMSUJfSU5TVEFMTF9ESVIgJHtDTUFLRV9JTlNUQUxMX1BSRUZJWH0vbGliKQ0K
K2VuZGlmKE5PVCBERUZJTkVEIExJQl9JTlNUQUxMX0RJUikNCisNCitpZihOT1QgREVGSU5FRCBJ
TkNfSU5TVEFMTF9ESVIpDQorc2V0KElOQ19JTlNUQUxMX0RJUiAke0NNQUtFX0lOU1RBTExfUFJF
RklYfS9pbmNsdWRlKQ0KK2VuZGlmKE5PVCBERUZJTkVEIElOQ19JTlNUQUxMX0RJUikNCisNCitp
ZihOT1QgREVGSU5FRCBQS0NfSU5TVEFMTF9ESVIpDQorc2V0KFBLQ19JTlNUQUxMX0RJUiAke0xJ
Ql9JTlNUQUxMX0RJUn0vcGtnY29uZmlnKQ0KK2VuZGlmKE5PVCBERUZJTkVEIFBLQ19JTlNUQUxM
X0RJUikNCisNCiBvcHRpb24oQlVJTERfdG9vbHMgImJ1aWxkIHRoZSB4bWx3ZiB0b29sIGZvciBl
eHBhdCBsaWJyYXJ5IiBPTikNCiBvcHRpb24oQlVJTERfZXhhbXBsZXMgImJ1aWxkIHRoZSBleGFt
cGxlcyBmb3IgZXhwYXQgbGlicmFyeSIgT04pDQogb3B0aW9uKEJVSUxEX3Rlc3RzICJidWlsZCB0
aGUgdGVzdHMgZm9yIGV4cGF0IGxpYnJhcnkiIE9OKQ0KQEAgLTYxLDM1ICs4NSwyNCBAQAogZW5k
aWYoQlVJTERfc2hhcmVkKQ0KIA0KIGFkZF9saWJyYXJ5KGV4cGF0ICR7X1NIQVJFRH0gJHtleHBh
dF9TUkNTfSkNCi0NCi1pbnN0YWxsKFRBUkdFVFMgZXhwYXQgUlVOVElNRSBERVNUSU5BVElPTiBi
aW4NCi0gICAgICAgICAgICAgICAgICAgICAgTElCUkFSWSBERVNUSU5BVElPTiBsaWINCi0gICAg
ICAgICAgICAgICAgICAgICAgQVJDSElWRSBERVNUSU5BVElPTiBsaWIpDQorc2V0X3RhcmdldF9w
cm9wZXJ0aWVzKGV4cGF0IFBST1BFUlRJRVMNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg
VkVSU0lPTiAke01BSk9SfS4ke01JTk9SfS4ke1BBVENIfQ0KKwkJCSAgICBTT1ZFUlNJT04gJHtN
QUpPUn0pDQorDQoraW5zdGFsbChUQVJHRVRTIGV4cGF0IFJVTlRJTUUgREVTVElOQVRJT04gJHtC
SU5fSU5TVEFMTF9ESVJ9DQorICAgICAgICAgICAgICAgICAgICAgIExJQlJBUlkgREVTVElOQVRJ
T04gJHtMSUJfSU5TVEFMTF9ESVJ9DQorICAgICAgICAgICAgICAgICAgICAgIEFSQ0hJVkUgREVT
VElOQVRJT04gJHtMSUJfSU5TVEFMTF9ESVJ9KQ0KIA0KIHNldChwcmVmaXggJHtDTUFLRV9JTlNU
QUxMX1BSRUZJWH0pDQotc2V0KGV4ZWNfcHJlZml4ICJcJHtwcmVmaXh9L2JpbiIpDQotc2V0KGxp
YmRpciAiXCR7cHJlZml4fS9saWIiKQ0KLXNldChpbmNsdWRlZGlyICJcJHtwcmVmaXh9L2luY2x1
ZGUiKQ0KK3NldChleGVjX3ByZWZpeCAiXCR7cHJlZml4fSIpDQorc2V0KGxpYmRpciAke0xJQl9J
TlNUQUxMX0RJUn0pDQorc2V0KGluY2x1ZGVkaXIgJHtJTkNfSU5TVEFMTF9ESVJ9KQ0KIGNvbmZp
Z3VyZV9maWxlKGV4cGF0LnBjLmluICR7Q01BS0VfQ1VSUkVOVF9CSU5BUllfRElSfS9leHBhdC5w
YykNCiANCi1pbnN0YWxsKEZJTEVTIGxpYi9leHBhdC5oIGxpYi9leHBhdF9leHRlcm5hbC5oIERF
U1RJTkFUSU9OIGluY2x1ZGUpDQotaW5zdGFsbChGSUxFUyAke0NNQUtFX0NVUlJFTlRfQklOQVJZ
X0RJUn0vZXhwYXQucGMgREVTVElOQVRJT04gbGliL3BrZ2NvbmZpZykNCi0NCi0NCitpbnN0YWxs
KEZJTEVTIGxpYi9leHBhdC5oIGxpYi9leHBhdF9leHRlcm5hbC5oIERFU1RJTkFUSU9OICR7SU5D
X0lOU1RBTExfRElSfSkNCitpbnN0YWxsKEZJTEVTICR7Q01BS0VfQ1VSUkVOVF9CSU5BUllfRElS
fS9leHBhdC5wYyBERVNUSU5BVElPTiAke1BLQ19JTlNUQUxMX0RJUn0pDQogDQotaWYoQlVJTERf
dG9vbHMgQU5EIE5PVCBXSU5DRSkNCi0gICAgc2V0KHhtbHdmX1NSQ1MNCi0gICAgICAgIHhtbHdm
L3htbHdmLmMNCi0gICAgICAgIHhtbHdmL3htbGZpbGUuYw0KLSAgICAgICAgeG1sd2YvY29kZXBh
Z2UuYw0KLSAgICAgICAgeG1sd2YvcmVhZGZpbGVtYXAuYw0KLSAgICApDQotDQotICAgIGFkZF9l
eGVjdXRhYmxlKHhtbHdmICR7eG1sd2ZfU1JDU30pDQotICAgIHRhcmdldF9saW5rX2xpYnJhcmll
cyh4bWx3ZiBleHBhdCkNCi0gICAgaW5zdGFsbChUQVJHRVRTIHhtbHdmIERFU1RJTkFUSU9OIGJp
bikNCi0gICAgaW5zdGFsbChGSUxFUyBkb2MveG1sd2YuMSBERVNUSU5BVElPTiBzaGFyZS9tYW4v
bWFuMSkNCi1lbmRpZihCVUlMRF90b29scyBBTkQgTk9UIFdJTkNFKQ0KK2FkZF9zdWJkaXJlY3Rv
cnkoeG1sd2YpDQogDQogaWYoQlVJTERfZXhhbXBsZXMpDQogICAgIGFkZF9leGVjdXRhYmxlKGVs
ZW1lbnRzIGV4YW1wbGVzL2VsZW1lbnRzLmMpDQpkaWZmIC1yIC11IC1OIGV4cGF0LTIuMS4wL3ht
bHdmL0NNYWtlTGlzdHMudHh0IGV4cGF0LTIuMS4wLWNtYWtlZml4ZXMveG1sd2YvQ01ha2VMaXN0
cy50eHQKLS0tIGV4cGF0LTIuMS4wL3htbHdmL0NNYWtlTGlzdHMudHh0CTE5NzAtMDEtMDEgMDE6
MDA6MDAuMDAwMDAwMDAwICswMTAwCisrKyBleHBhdC0yLjEuMC1jbWFrZWZpeGVzL3htbHdmL0NN
YWtlTGlzdHMudHh0CTIwMTMtMDEtMjQgMDQ6NTY6MzAuNDgwMDA1MDY3ICswMTAwCkBAIC0wLDAg
KzEsMTMgQEAKK2lmKEJVSUxEX3Rvb2xzIEFORCBOT1QgV0lOQ0UpCisgICAgc2V0KHhtbHdmX1NS
Q1MKKyAgICAgICAgeG1sd2YuYworICAgICAgICB4bWxmaWxlLmMKKyAgICAgICAgY29kZXBhZ2Uu
YworICAgICAgICByZWFkZmlsZW1hcC5jCisgICAgKQorCisgICAgYWRkX2V4ZWN1dGFibGUoeG1s
d2YgJHt4bWx3Zl9TUkNTfSkKKyAgICB0YXJnZXRfbGlua19saWJyYXJpZXMoeG1sd2YgZXhwYXQp
CisgICAgaW5zdGFsbChUQVJHRVRTIHhtbHdmIERFU1RJTkFUSU9OICR7QklOX0lOU1RBTExfRElS
fSkKKyAgICBpbnN0YWxsKEZJTEVTICR7Q01BS0VfU09VUkNFX0RJUn0vZG9jL3htbHdmLjEgREVT
VElOQVRJT04gJHtNQU5fSU5TVEFMTF9ESVJ9L21hbjEpCitlbmRpZihCVUlMRF90b29scyBBTkQg
Tk9UIFdJTkNFKQo=
--f46d042a0d619e332604d4014b97
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Expat-bugs mailing list
[email protected]
http://mail.libexpat.org/mailman/listinfo/expat-bugs

--f46d042a0d619e332604d4014b97--