[ expat-Bugs-767634 ] Build without XML_DTD define.

Bugs item #767634, was opened at 2003-07-08 05:15
Message generated for change (Comment added) made by kwaclaw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=767634&group_id=10127

Category: Build control
Group: None
Status: Closed
Resolution: Duplicate
Priority: 5
Submitted By: Maxim Petrovich Dementiev (maximdementiev)
Assigned to: Greg Stein (gstein)
Summary: Build without XML_DTD define.

Initial Comment:
Expat, Release 1.95.6
Platform: Borland C++ 5.5.1 for Win32 Copyright (c) 
1993, 2000 Borland
Undefinded options: XML_NS and XML_DTD.

Compile output:
------------------- begin -------------------------
Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 
Borland
.\xmlparse.c:
Error E2451 .\xmlparse.c 880: Undefined 
symbol 'isParamEntity' in function XML_SetEncoding
Error E2451 .\xmlparse.c 880: Undefined 
symbol 'externalParEntInitProcessor' in function 
XML_SetEncoding
Error E2451 .\xmlparse.c 1102: Undefined 
symbol 'isParamEntity' in function 
XML_SetReturnNSTriplet
Error E2451 .\xmlparse.c 1102: Undefined 
symbol 'externalParEntInitProcessor' in function 
XML_SetReturnNSTriplet
Error E2451 .\xmlparse.c 1354: Undefined 
symbol 'isParamEntity' in function 
XML_SetParamEntityParsing
Error E2451 .\xmlparse.c 1354: Undefined 
symbol 'externalParEntInitProcessor' in function 
XML_SetParamEntityParsing
*** 6 errors in Compile ***
-------------------- end ------------------------

----------------------------------------------------------------------

>Comment By: Karl Waclawek (kwaclaw)
Date: 2003-07-09 09:17

Message:
Logged In: YES 
user_id=290026

We haven't found time to build a new release from CVS yet.
There is also one patch left to be reviewed.

About the bug list: What is really missing is a display option
for the bug tracker that shows the resolution type for
closed bugs.

I am closing this bug report now as a duplicate of bug 
#679754.

----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2003-07-09 09:16

Message:
Logged In: YES 
user_id=290026

We haven't found time to build a new release from CVS yet.
There is also one patch left to be reviewed.

About the bug list: What is really missing is a display option
for the bug tracker that shows the resolution type for
closed bugs.

I am closing this bug report now as a duplicate of bug 
#679754.

----------------------------------------------------------------------

Comment By: Maxim Petrovich Dementiev (maximdementiev)
Date: 2003-07-09 03:07

Message:
Logged In: YES 
user_id=501042

Thank you for your job!
I find library very good.

PS: I downloaded 'expat_win32bin_1_95_6.exe' on 7 jule 
2003 when bug is realy fixed already.
Yes, CVS - is 'coolest' tool in the world - I respect.
I think it will be nice if there will be file like bugs.txt (may be 
use section in existing one) where sum well-known bugs with 
status (fixed, open).
PPS: Thank you again!

----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2003-07-08 12:58

Message:
Logged In: YES 
user_id=290026

This is not the case in my version of xmlparse.c.
I looked at fixed bugs and found bug #679754
which means it is fixed in CVS.

As it currently looks we don't have this problem anymore.


----------------------------------------------------------------------

Comment By: Maxim Petrovich Dementiev (maximdementiev)
Date: 2003-07-08 11:46

Message:
Logged In: YES 
user_id=501042

I'm sure it's error.
Let's look at 'xmlparse.c'.
Lines 610-626:
---------- begin ----------
#ifdef XML_DTD
#define isParamEntity (parser->m_isParamEntity)
#define useForeignDTD (parser->m_useForeignDTD)
#define paramEntityParsing (parser->m_paramEntityParsing)
#endif /* XML_DTD */

#define parsing \
  (parentParser \
    ? \
    (isParamEntity \
      ? \
      (processor != externalParEntInitProcessor) \
      : \
      (processor != externalEntityInitProcessor)) \
    : \
    (processor != prologInitProcessor))

---------- end ----------
We have symbol "isParamEntity" (only one declaration & 
definition - line 611) defined only if "XML_DTD" is definded. 
Right?
I greped all files in "Expat-1.95.6" archive and 
found "isParamEntity" only in one file - 'xmlparse.c'.
So macro "parsing" (line 616) always referes to symbol that 
may be undefined.
And my compiler supports me in that issue saying:
---------- begin ----------
..\lib\xmlparse.c: Error E2451 ..\lib\xmlparse.c 880: 
Undefined symbol 'isParamEntity' in function 
XML_SetEncoding
---------- end ----------
because at line 880 we have call to macro "parsing".


----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2003-07-08 11:08

Message:
Logged In: YES 
user_id=290026

When I am using the free command line compiler (bcc 5.5)
then it works fine for me, both with XML_NS and XML_DTD 
undefined. I simply commented them out in winconfig.h.

I was trying the version from CVS. Maybe you should give
that one a try too.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=767634&group_id=10127