[ expat-Bugs-896188 ] Not well-formed internal parameter entities

Bugs item #896188, was opened at 2004-02-12 17:11
Message generated for change (Comment added) made by jkloth
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=896188&group_id=10127

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Jeremy Kloth (jkloth)
Assigned to: Karl Waclawek (kwaclaw)
Summary: Not well-formed internal parameter entities

Initial Comment:
In testing against the XML Conformance Test Suites, we've 
discovered that Expat doesn't verify that internal parameter 
entities are well-formed (as per XML 1.0 3rd 4.3.2). 
 
Attached is a patch that fixes this and 2 example documents that 
demonstrate both valid and invalid behavior. 
 

----------------------------------------------------------------------

>Comment By: Jeremy Kloth (jkloth)
Date: 2004-02-12 19:28

Message:
Logged In: YES 
user_id=38980

Attached is the "Fix Explained" (hopefully) document. 

----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2004-02-12 19:02

Message:
Logged In: YES 
user_id=290026

OK, now I remember. If you look at bug #569461 there
was a discussion regarding these two test cases,
(a while back) and there I thought it would require some
time to understand the logic in Expat well enough for a fix.

This is cool - having a fix for that! Thanks!

I would like you to explain the logic behind the fix,
because I really don't want to "fix" Expat so short before
a new release unless I understand the fix and can reasonably
be sure it doesn't mess up anything else.

You might want to create a "Fix Explained" attachment
rather than a note, as this web interface really isn't
a good text editor.

----------------------------------------------------------------------

Comment By: Jeremy Kloth (jkloth)
Date: 2004-02-12 18:52

Message:
Logged In: YES 
user_id=38980

Actually, the error should be on line 4 (the %e; expansion).  I'm using a 
CVS (updated today) build. 
 
I've attached another invalid example to further demonstrate the 
problem. 
 
The XML Test Suite tests for this case are 
xmltest/not-wf/not-sa/010.xml and 011.xml 

----------------------------------------------------------------------

Comment By: Karl Waclawek (kwaclaw)
Date: 2004-02-12 18:13

Message:
Logged In: YES 
user_id=290026

I tried the current Expat (CVS), and it reports a syntax
error on line 5, column 0 for bad.xml. Is that not what it 
should do? Are you saying that your copy of Expat
doesn't do that? Which version are you using?

Which test cases of the XML conformance suite
does Expat not pass - related to this issue?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110127&aid=896188&group_id=10127