[jira] [Updated] (FOP-3239) Re-evaluate deprecation of Fop.getUserAgent()

     [ https://issues.apache.org/jira/browse/FOP-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joshua Marquart updated FOP-3239:
---------------------------------
    Description: 
class {color:#3f5fbf}org.apache.fop.apps.Fop{color} method {color:#3f5fbf}public FOUserAgent getUserAgent(){color} is deprecated with the following comment:
 
{color:#7f9fbf}@deprecated{color}{color:#3f5fbf} this getter doesn't need to exist. By virtue of the fact that the client has an instance of this object, it means they also have the {color}{color:#3f3fbf}{@link FOUserAgent}{color}{color:#3f5fbf} since this's constructor is only used in {color}{color:#3f3fbf}{@link FOUserAgent}{color}

This is not true if the {color:#3f5fbf}org.apache.fop.apps.FopFactory{color} method {color:#3f5fbf}public Fop newFop(String outputFormat, OutputStream stream){color} is used to create a {color:#3f5fbf}Fop{color} instance.  This method is not, itself, deprecated.

Recommend to either remove the deprecation on {color:#3f5fbf}getUserAgent(){color} or deprecate {color:#3f5fbf}org.apache.fop.apps.FopFactory{color} method {color:#3f5fbf}public Fop newFop(String outputFormat, OutputStream stream){color} in lieu of {color:#3f5fbf}org.apache.fop.apps.FopFactory{color} method {color:#3f5fbf}public Fop newFop(String outputFormat, FOUserAgent userAgent, OutputStream stream){color} 

  was:
class {color:#3f5fbf}org.apache.fop.apps.Fop{color} method {color:#3f5fbf}public FOUserAgent getUserAgent(){color} is deprecated with the following comment:
 
{color:#7f9fbf}@deprecated{color}{color:#3f5fbf} this getter doesn't need to exist. By virtue of the fact that the client has an instance of this object, it means they also have the {color}{color:#3f3fbf}{@link FOUserAgent}{color}{color:#3f5fbf} since this's constructor is only used in {color}{color:#3f3fbf}{@link FOUserAgent}{color}

This is not true if the {color:#3f5fbf}org.apache.fop.apps.FopFactory{color} method {color:#3f5fbf}public Fop newFop(String outputFormat, OutputStream stream){color} is used to create a {color:#3f5fbf}Fop{color} instance.  This method is not, itself, deprecated.

Recommend to remove the deprecation on {color:#3f5fbf}getUserAgent(){color} 


> Re-evaluate deprecation of Fop.getUserAgent()
> ---------------------------------------------
>
>                 Key: FOP-3239
>                 URL: https://issues.apache.org/jira/browse/FOP-3239
>             Project: FOP
>          Issue Type: Bug
>    Affects Versions: 2.10
>            Reporter: Joshua Marquart
>            Priority: Trivial
>
> class {color:#3f5fbf}org.apache.fop.apps.Fop{color} method {color:#3f5fbf}public FOUserAgent getUserAgent(){color} is deprecated with the following comment:
>  
> {color:#7f9fbf}@deprecated{color}{color:#3f5fbf} this getter doesn't need to exist. By virtue of the fact that the client has an instance of this object, it means they also have the {color}{color:#3f3fbf}{@link FOUserAgent}{color}{color:#3f5fbf} since this's constructor is only used in {color}{color:#3f3fbf}{@link FOUserAgent}{color}
> This is not true if the {color:#3f5fbf}org.apache.fop.apps.FopFactory{color} method {color:#3f5fbf}public Fop newFop(String outputFormat, OutputStream stream){color} is used to create a {color:#3f5fbf}Fop{color} instance.  This method is not, itself, deprecated.
> Recommend to either remove the deprecation on {color:#3f5fbf}getUserAgent(){color} or deprecate {color:#3f5fbf}org.apache.fop.apps.FopFactory{color} method {color:#3f5fbf}public Fop newFop(String outputFormat, OutputStream stream){color} in lieu of {color:#3f5fbf}org.apache.fop.apps.FopFactory{color} method {color:#3f5fbf}public Fop newFop(String outputFormat, FOUserAgent userAgent, OutputStream stream){color} 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)