Re: [jira] [Created] (FOP-3277) [PATCH] Add font substitution support for PDFTranscoder

Hi Simon,

thanks, that worked...

One last issue: I don't seem to be able to merge my own GitHub pull 
request, e.g. https://github.com/apache/xmlgraphics-fop/pull/91

Maybe at least one other dev needs to review and approve it first? I 
guess I could just merge it via GIT, but I think it's better, that you 
or any other committer can have a look before modifying the main branch.

Thanks,
Matthias

On 10/10/2025 12:06, Simon Steiner wrote:
> Hi,
>
> Can you check
> https://infra.apache.org/apache-github.html
>
> Thanks
>
> -----Original Message-----
> From: Matthias Reischenbacher <[email protected]>
> Sent: 10 October 2025 15:52
> To: [email protected]
> Subject: Re: [jira] [Created] (FOP-3277) [PATCH] Add font substitution support for PDFTranscoder
>
> Hi Simon,
>
> thanks for your help, I could successfully push my branch.
>
> Now I'm trying to create a pull request via the link
> https://github.com/apache/xmlgraphics-fop/pull/new/FOP-3277 , but I get the error message "Pull request creation failed. Validation failed: must be a collaborator".
>
> I'm logged-in with my personal Github account (but linked also the apache email address). Do I need to login with a different account?
>
> Thanks,
> Matthias
>
> On 10/10/2025 11:17, Simon Steiner wrote:
>> Hi,
>>
>> Try using
>> https://[email protected]/repos/asf/xmlgraphics-fop.git
>>
>> Thanks
>>
>> -----Original Message-----
>> From: Matthias Reischenbacher <[email protected]>
>> Sent: 10 October 2025 14:39
>> To: [email protected]
>> Subject: Re: [jira] [Created] (FOP-3277) [PATCH] Add font substitution
>> support for PDFTranscoder
>>
>> Hi,
>>
>> who can configure my Github user (matthias8283) with read/write rights in https://github.com/apache/xmlgraphics-fop ?
>>
>> I'd like to start pushing many of the changes we have developed for FOP over the years to the main branch. This ticket would be the first one.
>>
>> Thanks,
>> Matthias
>>
>> On 10/10/2025 10:34, Matthias Reischenbacher (Jira) wrote:
>>> Matthias Reischenbacher created FOP-3277:
>>> --------------------------------------------
>>>
>>>                 Summary: [PATCH] Add font substitution support for PDFTranscoder
>>>                     Key: FOP-3277
>>>                     URL: https://issues.apache.org/jira/browse/FOP-3277
>>>                 Project: FOP
>>>              Issue Type: Improvement
>>>              Components: renderer/pdf
>>>                Reporter: Matthias Reischenbacher
>>>                Assignee: Matthias Reischenbacher
>>>
>>>
>>> When using a PDF transcoder configuration like the following
>>> {code:java} <?xml version="1.0" encoding="utf-8"?> <pdf-renderer>
>>>      <fonts>
>>>        <substitutions>
>>>          <substitution>
>>>            <from font-family="Helvetica"/>
>>>            <to font-family="Courier"/>
>>>          </substitution>
>>>        </substitutions>
>>>      </fonts>
>>> </pdf-renderer>
>>> {code}
>>> then the "substitutions" configuration is currently ignored. The attached patch fixes this issue.
>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian Jira
>>> (v8.20.10#820010)