Re: [PR] Adding hashcode to DOMKeyValue [santuario-xml-sec urity-java]

seanjmullan commented on code in PR #476:
URL: https://github.com/apache/santuario-xml-security-java/pull/476#discussion_r2098527735


##########
src/main/java/org/apache/jcp/xml/dsig/internal/dom/DOMKeyValue.java:
##########
@@ -261,9 +261,26 @@ public boolean equals(Object obj) {
                         && rsaKey.getModulus().equals(otherRSAKey.getModulus());
             } catch (KeyException ke) {
                 // no practical way to determine if the keys are equal
-                return false;
+                return super.equals(obj);

Review Comment:
   Actually, I take back my comment here - returning false as originally is ok (and better) since it already checked if the objects were the same on line 243.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]