Re: [PR] Added properties for base64 formatting [santuario -xml-security-java]

seanjmullan (via GitHub) <[email protected]> Fri, 07 Nov 2025 14:24:56 -0000

Newsgroups	gmane.text.xml.security.devel
Message-ID	<PR_kwDOD7oF986jGHuo-9af04a12-e0cc-4397-b6c4-686efbefdd3a@gitbox.apache.org>

seanjmullan commented on code in PR #504:
URL: https://github.com/apache/santuario-xml-security-java/pull/504#discussion_r2503813009


##########
src/main/java/org/apache/xml/security/utils/XMLUtils.java:
##########


Review Comment:
   Did you consider testing the properties by generating signed XML and then checking the format? This test won't catch issues where the internal methods are not called accidentally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]