Re: [PR] [SANTUARIO-615] xades extension implementation [santuario-xml-security-java]

jrihtarsic commented on PR #617:
URL: https://github.com/apache/santuario-xml-security-java/pull/617#issuecomment-4980335126

   Hi @coheigea 
   
   Is it possible 
   To review the following two PRs regarding XAdES-B
   First this one:
       https://github.com/apache/santuario-xml-security-java/pull/616 - adds the feature to be able to implement pre/post processors to the signature
   
   And then this:    
       https://github.com/apache/santuario-xml-security-java/pull/617 - This PR builds on the feature introduced in PR 616 and provides an implementation of the XAdES‑B profile. 
   
   In the second M 617 R I also added a tool     
   src/test/java/org/apache/xml/security/testutils/SelfSignedCertGenerator.java
   
   which generates simple test certificates on the fly so that there is no need to add  new keystore/truststore binaries for new key types. The tool is intentionally minimal, has no external dependencies, and is reusable for future work, including for the future contributions on Post‑Quantum Cryptography.
    I created it because Mr. @seanjmullan previously raised concerns when I added keystores for the X25519/X448 and EdDSA use-cases, and this now serves as the alternative.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]