Re: [PR] Add PQC (ML-DSA and ML-KEM) support for XML Dig ital Signature and Enc… [santuario-xml-security-java]

ffang commented on PR #645:
URL: https://github.com/apache/santuario-xml-security-java/pull/645#issuecomment-5371162142

   > Arpan0995
   
   Hi @Arpan0995,
   
   Thanks for going ahead and implementing these — nice catch keeping them parameterized across all three parameter sets, that's cleaner than what I had.
   
   FYI, I'd already been working on adding negative-test coverage, and mine covers both the DOM and STAX paths . But your @ParameterizedTest/@CsvSource approach, parameterized across all three parameter sets, is cleaner than the single hardcoded case I used — I'd like to bring that in.
   
   The split PRs are up now:
   
   - #651 — ML-DSA (signature) — negative-test coverage on both the DOM/JSR-105 and STAX paths (tampered SignatureValue rejected, wrong public key rejected)
   - #652 — ML-KEM (encryption) — negative-test coverage on both the DOM and STAX paths (wrong recipient key fails cleanly, truncated EncryptedKey ciphertext rejected)
   
   Would you mind rebasing your parameterization against #651/#652 (ML-DSA cases → #651, ML-KEM cases → #652)? Happy to help however's easiest — a PR against my branch, or a patch pasted here.
   
   Cheers
   Freeman
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]