Re: [WSS4J] WSDoAllReceiver ignoring Actor when calling Security engine?

Davanum Srinivas <dims-/[email protected]> Sat, 7 Feb 2004 12:07:53 -0800 (PST)
Newsgroups gmane.text.xml.wss4j
Message-ID <[email protected]>
replaced null with actor. is this enough?

thanks,
dims

Index: src/org/apache/ws/axis/security/WSDoAllReceiver.java
===================================================================
RCS file: /cvsroot/wss4j/wss4j/src/org/apache/ws/axis/security/WSDoAllReceiver.java,v
retrieving revision 1.10
diff -d -u -b -B -w -u -r1.10 WSDoAllReceiver.java
--- src/org/apache/ws/axis/security/WSDoAllReceiver.java        22 Dec 2003 13:36:11 -0000     
1.10
+++ src/org/apache/ws/axis/security/WSDoAllReceiver.java        7 Feb 2004 20:03:09 -0000
@@ -202,7 +202,7 @@
                        wsResult =
                                secEngine.processSecurityHeader(
                                        doc,
-                                       null,
+                                       actor,
                                        cbHandler,
                                        sigCrypto,
                                        decCrypto);

--- Jason Essington <[email protected]> wrote:
> Hi there
> 
> It looks like the WSDoAllReceiver is not passing the actor on to the 
> WSSecurityEngine . . .:
> 	wsResult =
> 		secEngine.processSecurityHeader(
> 			doc,
> 			null,  // <-- this should be the actor
> 			cbHandler,
> 			sigCrypto,
> 			decCrypto);
> 
> In my (test) case where I have only 1 actor and it's not the default 
> (or rather nonexistent) actor, this causes the security engine to 
> return a result of null.
> 
> That causes a NPE at the line:
> 		Vector resultActions = wsResult.getActions();
> Since there are no security actions performed by the null actor.
> 
> Simply supplying the actor solves this problem, and avoids any 
> possibility of an NPE.
> 
> -jason
> 
> 

> ATTACHMENT part 2 application/octet-stream x-unix-mode=0644; name=doAllActor.patch
> 
> 


=====
Davanum Srinivas - http://webservices.apache.org/~dims/


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn