svn commit: r1225390 - /xalan/java/trunk/src/org/apache/xalan/xsltc/dom/SAXImpl.java

[email protected] Wed, 28 Dec 2011 23:29:18 -0000
Newsgroups gmane.text.xml.xalan.cvs
Message-ID <[email protected]>
Author: mrglavas
Date: Wed Dec 28 23:29:18 2011
New Revision: 1225390

URL: http://svn.apache.org/viewvc?rev=1225390&view=rev
Log:
Minor performance improvement. Iterate over the entries in the map instead of the keys. This avoids a redundant table lookup for each value.

Modified:
    xalan/java/trunk/src/org/apache/xalan/xsltc/dom/SAXImpl.java

Modified: xalan/java/trunk/src/org/apache/xalan/xsltc/dom/SAXImpl.java
URL: http://svn.apache.org/viewvc/xalan/java/trunk/src/org/apache/xalan/xsltc/dom/SAXImpl.java?rev=1225390&r1=1225389&r2=1225390&view=diff
==============================================================================
--- xalan/java/trunk/src/org/apache/xalan/xsltc/dom/SAXImpl.java (original)
+++ xalan/java/trunk/src/org/apache/xalan/xsltc/dom/SAXImpl.java Wed Dec 28 23:29:18 2011
@@ -22,6 +22,8 @@
 package org.apache.xalan.xsltc.dom;
 
 import java.util.Enumeration;
+import java.util.Iterator;
+import java.util.Map;
 
 import javax.xml.transform.Source;
 import javax.xml.transform.dom.DOMSource;
@@ -1843,17 +1845,16 @@ public final class SAXImpl extends SAX2D
         }
 
         // Convert a java.util.Hashtable to an xsltc.runtime.Hashtable
-        Enumeration idValues = m_idAttributes.keys();
-        if (!idValues.hasMoreElements()) {
+        Iterator idEntries = m_idAttributes.entrySet().iterator();
+        if (!idEntries.hasNext()) {
             return null;
         }
 
         Hashtable idAttrsTable = new Hashtable();
-
-        while (idValues.hasMoreElements()) {
-            Object idValue = idValues.nextElement();
-
-            idAttrsTable.put(idValue, m_idAttributes.get(idValue));
+        
+        while (idEntries.hasNext()) {
+            Map.Entry entry = (Map.Entry) idEntries.next();
+            idAttrsTable.put(entry.getKey(), entry.getValue());
         }
 
         return idAttrsTable;