Re: xalan-j releases discussion

On Sun, Jul 27, 2025 at 12:43 PM Mukul Gandhi <[email protected]>
wrote:

> Hi Gary,
>     Thanks for your review feedback about this work.
>
> On Sun, Jul 27, 2025 at 7:53 PM Gary Gregory <[email protected]>
> wrote:
> > Please accept my apologies for the delay in starting a review.
>
> That's ok, please.
>
> > I did NOT edit:
> >
> >     public static final String LOCAL_BASE_URI_PREFIX_FOR_TESTS_1 =
> "file:/d:/eclipseWorkspaces/xalanj/xalan-j_xslt3.0_mvn/src/test/resources/";
> >
> >     public static final String LOCAL_BASE_URI_PREFIX_FOR_TESTS_2 =
> "file:/d:///eclipseWorkspaces/xalanj/xalan-j_xslt3.0_mvn/src/test/resources/";
> >
> > The above is bad since a build should be able to run without a tester
> editing source code.
> >
> > By default, a Maven project will have it's folder "src/test/resources/"
> on its classpath, so these files can be accessed either as resources or
> using a relative path
> >
> > Why have two Maven steps?
> >
> > Why not:
> >
> > mvn clean install test -Dtest=AllXalanXSLT3Tests
>
> I've made all these suggested changes, and have modified readme
> document as well.
>
> You may please verify the corrections I've made as per your feedback.
>

Hi Mukul:

The build still fails for me with 3 errors instead of 5 (progress!):

[INFO] --- surefire:2.22.0:test (default-test) @ xalan-java ---
[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.xalan.tests.main.AllXalanXSLT3Tests
[ERROR] Tests run: 1183, Failures: 3, Errors: 0, Skipped: 0, Time elapsed:
2.486 s <<< FAILURE! - in org.apache.xalan.tests.main.AllXalanXSLT3Tests
[ERROR] xslFnTransformTest9(org.apache.xalan.tests.xpath3.FnTransformTests)
 Time elapsed: 0.004 s  <<< FAILURE!
junit.framework.AssertionFailedError
at
org.apache.xalan.tests.xpath3.FnTransformTests.xslFnTransformTest9(FnTransformTests.java:137)

[ERROR]
xslFnTransformTest11(org.apache.xalan.tests.xpath3.FnTransformTests)  Time
elapsed: 0.005 s  <<< FAILURE!
junit.framework.AssertionFailedError
at
org.apache.xalan.tests.xpath3.FnTransformTests.xslFnTransformTest11(FnTransformTests.java:157)

[ERROR]
xslFnTransformTest12(org.apache.xalan.tests.xpath3.FnTransformTests)  Time
elapsed: 0.005 s  <<< FAILURE!
junit.framework.AssertionFailedError
at
org.apache.xalan.tests.xpath3.FnTransformTests.xslFnTransformTest12(FnTransformTests.java:167)

[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]
FnTransformTests.xslFnTransformTest11:157->XslTransformTestsUtil.runXslTransformAndAssertOutput:170
[ERROR]
FnTransformTests.xslFnTransformTest12:167->XslTransformTestsUtil.runXslTransformAndAssertOutput:170
[ERROR]
FnTransformTests.xslFnTransformTest9:137->XslTransformTestsUtil.runXslTransformAndAssertOutput:170
[INFO]
[ERROR] Tests run: 1183, Failures: 3, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time:  6.769 s
[INFO] Finished at: 2025-07-27T15:19:52-04:00
[INFO]
------------------------------------------------------------------------

Gary

>
>
> --
> Regards,
> Mukul Gandhi
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>