Re: Minor xalan-test flaw, worth fixing?

OK, if it's a single Jira, that's fine; just needed to sanity check.


(Unnecessary refresher: Xalan-test was/is its own development project, since it was shared between xalan-j, xalan-c, and (it was intended) other xpath/xslt implementations. Which is the hassle w/r/t the source bundles; the decision was made to include the tests in that, which means the tests need to be cloned in before that step runs. Which is the part I need to finish off before we commit to MVN.)

Since xalan-c has been shelved, it's unclear anyone else is still using xalan-test, and bandwidth/storage are no longer significant issues, one can debate whether xalan-test should continue to be its own project or migrate/merge into xalan-java's test/ tree.

--
` /_     Joe Kesselman (he/him/his)
-/ _)    My Alexa skill for New Music/New Sounds fans:
  /      https://www.amazon.com/dp/B09WJ3H657/
Caveat: Opinionated old geezer with overcompensated writer's block. May be redundant, verbose, prolix, sesquipedalian, didactic, officious, or redundant. Feel free to call him on it.
________________________________
From: Gary Gregory <[email protected]>
Sent: Tuesday, August 5, 2025 6:53 PM
To: [email protected] <[email protected]>
Subject: Re: Minor xalan-test flaw, worth fixing?

Hi Joe,

All of Xalan-Java should live in the same Jira project, or at least I hope it does.

Gary


On Tue, Aug 5, 2025, 18:43 Joseph Kesselman <[email protected]> wrote:
(Xalan-test has plenty of design flaws, but I happened to notice this one and I'm not sure it's been recorded as an issue...)

Trying to get back to finishing the Ant build's missing step (bundling xalan-test into the source-release archive file). I am still not wild about that behavior, but the goal is to replicate the Ant build...


While looking at this I noticed a flaw in my build.sh (probably in the build.bat too) : The script does not return the exit code from the ant run, which makes checking the result of a test invoked programmatically annoying at best.

This is easily fixed by changing the final

  echo "build.sh complete!"

to

  ant_rc=$?
  echo "build.sh complete with return code" $ant_rc
  exit $ant_rc

(Note that we need to save $? Into a variable since echo's return code overwrites $?)


I've forgotten: Do we have a separate Jira for xalan-test, or are we just documenting changes to it  under xalan-java?



--
` /_     Joe Kesselman (he/him/his)
-/ _)    My Alexa skill for New Music/New Sounds fans:
  /      https://www.amazon.com/dp/B09WJ3H657/
Caveat: Opinionated old geezer with overcompensated writer's block. May be redundant, verbose, prolix, sesquipedalian, didactic, officious, or redundant. Feel free to call him on it.