Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC10

--00000000000068f7c905f7cd1a31
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thank you Mukul for this RC.

+1

- Reviewing src zip: ASC, SHA files OK.
- Building runtime with 'chmod +x ./build.sh && ./build.sh clean fulldist'
OK.
- Following the README, there is confusion because the unzipped src zip
creates a `xalan-test` folder as a child folder but the README describes it
as a sibling folder. Does this skew the tests or cause issues?
- TODOs later:
-- Fix Javadoc errors
-- Test output should be quieter in non-debug mode: No need to tell me all
the test files that PASS, I have no idea if I am missing any failure output
without tediously reviewing ALL console output.

Using:

ant -version
Apache Ant(TM) version 1.10.13 compiled on January 4 2023

java -version
openjdk version "1.8.0_362"
OpenJDK Runtime Environment (build 1.8.0_362-bre_2023_01_22_03_32-b00)
OpenJDK 64-Bit Server VM (build 25.362-b00, mixed mode)

uname -a
Darwin *** 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:42:11 PST
2023; root:xnu-8792.81.3~2/RELEASE_X86_64 x86_64

Gary


On Sat, Mar 25, 2023 at 11:32=E2=80=AFAM Mukul Gandhi <[email protected]> w=
rote:

> Hi all,
>      I've published the new RC for XalanJ 2.7.3 release (located at
> https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC10/). This RC,
> uses Apache Commons BCEL 6.7.0, and also provides means to build and
> test XalanJ from the source distribution.
>
> Since the previous XalanJ RC, this RC provides following improvements,
> 1) Few improvements to the XalanJ implementation and tests build
> scripts, based on feedback from XalanJ list members.
> 2) New linux build scripts, for XalanJ implementation and tests builds.
> 3) Implementation of few new XalanJ tests, for the jira issues solved
> for XalanJ 2.7.3.
> 4) Upgrade to the latest jtidy library (that parses XalanJ tests
> output HTML documents).
> 5) Suppression of few error messages, during XalanJ tests build, whose
> context was not clear.
>
> The apache git tags corresponding to this RC, are following (these
> have been committed as well),
> xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc10
> xalan-test repos (branch master) : xalan-j_2_7_3-rc10
>
> I've verified the working of this RC, both on windows and linux
> platforms, and necessary build tests pass as discussed during review
> of XalanJ RC9.
>
> The key that can be used, to verify this RC is located within the
> file, at https://dlcdn.apache.org/xalan/xalan-j/KEYS.
>
> The XalanJ readme file, has been updated here
>
> https://gitbox.apache.org/repos/asf?p=3Dxalan-java.git;a=3Dblob_plain;f=
=3DREADME;hb=3Drefs/heads/xalan-j_2_7_1_maint
> ,
> describing the XalanJ build and tests process.
>
> Kindly review and vote, for this XalanJ 2.7.3 RC.
>
> Great work everyone. Here's my +1 for this RC.
>
>
> --
> Regards,
> Mukul Gandhi
>

--00000000000068f7c905f7cd1a31
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Thank you Mukul for this RC.</div><div><br></div>+1<d=
iv><br>- Reviewing src zip: ASC, SHA files OK.<br>- Building runtime with &=
#39;chmod +x ./build.sh &amp;&amp; ./build.sh clean fulldist&#39; OK.<br>- =
Following=C2=A0the README, there is confusion because the unzipped src zip =
creates a `xalan-test` folder as a child folder but the README describes it=
 as a sibling folder. Does this skew the tests or cause issues?<div>- TODOs=
 later:</div><div>-- Fix Javadoc errors</div><div>-- Test output should be =
quieter in non-debug mode: No need to tell me all the test files that PASS,=
 I have no idea if I am missing any failure output without=C2=A0tediously r=
eviewing ALL console output.<br><div><br>Using:<br><br>ant -version<br>Apac=
he Ant(TM) version 1.10.13 compiled on January 4 2023<br><br>java -version<=
br>openjdk version &quot;1.8.0_362&quot;<br>OpenJDK Runtime Environment (bu=
ild 1.8.0_362-bre_2023_01_22_03_32-b00)<br>OpenJDK 64-Bit Server VM (build =
25.362-b00, mixed mode)<br><br>uname -a<br>Darwin *** 22.3.0 Darwin Kernel =
Version 22.3.0: Mon Jan 30 20:42:11 PST 2023; root:xnu-8792.81.3~2/RELEASE_=
X86_64 x86_64<br><br>Gary</div></div></div></div><br><br><div class=3D"gmai=
l_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Mar 25, 2023 at 11:3=
2=E2=80=AFAM Mukul Gandhi &lt;<a href=3D"mailto:[email protected]">mukulg@a=
pache.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">Hi all,<br>
=C2=A0 =C2=A0 =C2=A0I&#39;ve published the new RC for XalanJ 2.7.3 release =
(located at<br>
<a href=3D"https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC10/" rel=
=3D"noreferrer" target=3D"_blank">https://dist.apache.org/repos/dist/dev/xa=
lan/j/2.7.3/RC10/</a>). This RC,<br>
uses Apache Commons BCEL 6.7.0, and also provides means to build and<br>
test XalanJ from the source distribution.<br>
<br>
Since the previous XalanJ RC, this RC provides following improvements,<br>
1) Few improvements to the XalanJ implementation and tests build<br>
scripts, based on feedback from XalanJ list members.<br>
2) New linux build scripts, for XalanJ implementation and tests builds.<br>
3) Implementation of few new XalanJ tests, for the jira issues solved<br>
for XalanJ 2.7.3.<br>
4) Upgrade to the latest jtidy library (that parses XalanJ tests<br>
output HTML documents).<br>
5) Suppression of few error messages, during XalanJ tests build, whose<br>
context was not clear.<br>
<br>
The apache git tags corresponding to this RC, are following (these<br>
have been committed as well),<br>
xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc10<br>
xalan-test repos (branch master) : xalan-j_2_7_3-rc10<br>
<br>
I&#39;ve verified the working of this RC, both on windows and linux<br>
platforms, and necessary build tests pass as discussed during review<br>
of XalanJ RC9.<br>
<br>
The key that can be used, to verify this RC is located within the<br>
file, at <a href=3D"https://dlcdn.apache.org/xalan/xalan-j/KEYS" rel=3D"nor=
eferrer" target=3D"_blank">https://dlcdn.apache.org/xalan/xalan-j/KEYS</a>.=
<br>
<br>
The XalanJ readme file, has been updated here<br>
<a href=3D"https://gitbox.apache.org/repos/asf?p=3Dxalan-java.git;a=3Dblob_=
plain;f=3DREADME;hb=3Drefs/heads/xalan-j_2_7_1_maint" rel=3D"noreferrer" ta=
rget=3D"_blank">https://gitbox.apache.org/repos/asf?p=3Dxalan-java.git;a=3D=
blob_plain;f=3DREADME;hb=3Drefs/heads/xalan-j_2_7_1_maint</a>,<br>
describing the XalanJ build and tests process.<br>
<br>
Kindly review and vote, for this XalanJ 2.7.3 RC.<br>
<br>
Great work everyone. Here&#39;s my +1 for this RC.<br>
<br>
<br>
--<br>
Regards,<br>
Mukul Gandhi<br>
</blockquote></div>

--00000000000068f7c905f7cd1a31--