[GitHub] [xerces-c] rleigh-codelibre commented on pull req uest #23: fix static linking with curl

GitBox <[email protected]> Sat, 17 Oct 2020 21:02:02 -0000

Newsgroups	gmane.text.xml.xerces-c.devel
Message-ID	<[email protected]>

rleigh-codelibre commented on pull request #23:
URL: https://github.com/apache/xerces-c/pull/23#issuecomment-711079959


   I'm not keen on replacing the standard FindCURL.cmake with pkg-config.  It's less portable, and I would also suspect it will not export the dependency properly for reuse in downstream projects linking against xerces.  This needs to work on Windows as well as UNIX.
   
   If FindCURL.cmake isn't working properly, I would suggest that the preferred course of action should be to fix its behaviour rather than work around it.  This will ensure it will work correctly in all projects linking libCURL, rather than selectively changing a single project to work around the problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]