[jira] [Commented] (XERCESC-2231) (windows build) Generated resource file has trailing Nulls which appears to not compile correctly

    [ https://issues.apache.org/jira/browse/XERCESC-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448403#comment-17448403 ] 

Rod Widdowson commented on XERCESC-2231:
----------------------------------------

Thanks.  I’ll go back and look at our older installers to confirm over the holidays,

but the trailing nulls thing is pure supposition on my part, I’ll try to find time to do a build with that changed to confirm it one way or another,

> (windows build) Generated resource file has trailing Nulls which appears to not compile correctly
> -------------------------------------------------------------------------------------------------
>
>                 Key: XERCESC-2231
>                 URL: https://issues.apache.org/jira/browse/XERCESC-2231
>             Project: Xerces-C++
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 3.2.2, 3.2.3
>         Environment: Windows CMAKE build
>            Reporter: Rod Widdowson
>            Priority: Major
>
> We just noticed this but I suspect it goes back a long way.  Our build of xerces is notably short of string resources:
> {code:java}
>  C:\program files (x86)\shibboleth\sp\lib\xerces-c_3_2.dll:
>         Verified:       Unsigned
>         Link date:      16:29 09/04/2020
>         Publisher:      n/a
>         Company:        n/a
>         Description:    n/a
>         Product:        n/a
>         Prod version:   n/a
>         File version:   n/a
>         MachineType:    32-bit
>         Binary Version: 3.2.3.0
>         Original Name:  n/a
>         Internal Name:  n/a
>         Copyright:      n/a
>         Comments:       n/a
>         Entropy:        6.231{code}
> I could go back to find out when this started if needs be, but I'd guess it started when the project moved to CMAKE.
> the Generated rc file looks suspicious
> {code:java}
> VALUE "Comments", "Dynamic linked library for Xerces-C++\0"
> VALUE "CompanyName", "Apache Software Foundation\0"
> VALUE "FileDescription", "Shared Library for Xerces-C++ Version 3.2.3\0"
> VALUE "FileVersion", "3, 2, 3\0"
> VALUE "InternalName", XERCES_DLL_NAME
> VALUE "LegalCopyright", "Copyright © 1999-2018 Apache Software Foundation; subject to licensing terms\0"
> VALUE "LegalTrademarks", "\0"
> VALUE "OriginalFilename", XERCES_DLL_NAME
> VALUE "PrivateBuild", "\0"
> VALUE "ProductName", "Xerces-C++ Version 3.2.3\0"
> VALUE "ProductVersion", "3, 2, 3\0"
> VALUE "SpecialBuild", "\0"
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)