[GitHub] [xerces-c] rouault commented on pull request #4 7: [XERCESC-2188] Fix potential double-free in usage of Rea derMgr::pushReader()

GitBox <[email protected]> Tue, 25 Jan 2022 17:06:14 -0000

Newsgroups	gmane.text.xml.xerces-c.devel
Message-ID	<[email protected]>

rouault commented on pull request #47:
URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1021224266


   > I cant see how my changes could cause a test regression, all my change does is delete 4 smart pointers that are not used in the code base.
   
   yes, but that causes a memory leak since nobody would take care of freeing the declDTD object. Hence my extra changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]