[GitHub] [xerces-c] rleigh-codelibre commented on pull req uest #31: XERCESC-2219: [Backport 3.2] XMLReader cons tructor: fix memory leak when refreshRawBuffer() throws

rleigh-codelibre commented on PR #31:
URL: https://github.com/apache/xerces-c/pull/31#issuecomment-1268948199

   I thought MSVC linked by name rather than by ordinal when you used `__declspec`?  We aren't manually assigning ordinals in a `.def` file, we're linking by name, and the ordinals are sequentially assigned, and aren't used when linking either at build time or run time?
   
   If you run `dumpbin /EXPORTS` on the .lib and .dll you'll see that the lib file has names, the dll has both ordinals and names.  If you run `dumpbin /IMPORTS` on any of the exes you'll see that it has both ordinals and names.  My understanding of this is that the ordinals have to be unique but are otherwise a Win16 legacy and aren't used when the names are present--and for Xerces-C++ it will be using the names.
   
   I don't think there is an ABI issue here.  However, I'm not a Windows COFF expert.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]