[GitHub] [xerces-c] scantor commented on pull request #4 7: [XERCESC-2188] Fix potential double-free in usage of Rea derMgr::pushReader()

scantor commented on PR #47:
URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1688301972

   There are nowhere near adequate tests to treat that as meaningful, it's merely a data point. It's known when somebody who knows the code reviews the change for correctness. There are no active committers left who know the code, QED.
   
   There's a comment above that makes a case that this fix introduces a bug, i.e. a regression. Maybe it does, maybe it doesn't. That's plenty good enough for me to treat it as suspect.
   
   As for your customer, if you need the project to be viable, then you need to provide ongoing committers to make it viable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]