Re: [PR] [XERCESJ-841] VersionNotSupported message shoul d be same for sub-classes of XMLScanner [xerces-j]
mukulga (via GitHub) <[email protected]> Wed, 21 Jan 2026 11:30:50 -0000
| Newsgroups | gmane.text.xml.xerces-j.devel |
|---|---|
| Message-ID | <PR_kwDOLzdO6M61aLv--10b639ca-3ff4-4dd1-8b5a-42af8d202d3e@gitbox.apache.org> |
mukulga commented on code in PR #67:
URL: https://github.com/apache/xerces-j/pull/67#discussion_r2712156136
##########
src/org/apache/xerces/impl/msg/XMLMessages.properties:
##########
@@ -105,8 +105,7 @@
PI_NOT_IN_ONE_ENTITY = The processing instruction is not enclosed in the same entity.
# 2.8 Prolog and Document Type Declaration
VersionInfoInvalid = Invalid version \"{0}\".
- VersionNotSupported = XML version \"{0}\" is not supported, only XML 1.0 is supported.
- VersionNotSupported11 = XML version \"{0}\" is not supported, only XML 1.0 and XML 1.1 are supported.
+ VersionNotSupported = XML version \"{0}\" is not supported, only XML 1.0 and XML 1.1 are supported.
Review Comment:
> I need to think about this. As I recall, it is possible to configure Xerces to only support XML 1.0 and not 1.1, and I've done that.
I agree with @elharo
imho, I don't think, Apache Xerces Java should have change to VersionNotSupported's error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]