Re: [PR] Convert dom.ids.Test to JUnit 3 [xerces-j]

elharo commented on PR #103:
URL: https://github.com/apache/xerces-j/pull/103#issuecomment-4918116793

   fixed 
   
    PR #100 (range): Build failed on XML parse error in build.xml:919. The <java fork="yes" for dom.range.Test was     
        orphaned when the classname through </java> lines were removed. Fixed — removed the dangling line. All 7 range     
        tests pass.                                                                                                        
                                                                                                                           
        PR #103 (ids): Build failed on compilation error: variable doc might not have been initialized at Test.java:104.   
        The try/catch with fail() doesn't convince the compiler that doc is always initialized. Fixed — changed Document   
        doc; to Document doc = null;.                                                                                      
                                                                                                                           
        PR #107 (testns): Test fails on assertTrue("Output should contain xx:attr", output.contains("xx:attr")) at         
        TestNS.java:116. The xerces LSSerializer doesn't output the qualified name xx:attr — it generates a different      
        prefix. This is a pre-existing bug in the serializer: the original main()-driven test printed output but never     
        validated it, so this failure was invisible. Left alone per instructions.       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]